From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B522F1F4B8 for ; Tue, 30 Apr 2024 21:05:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=LlsnbLmv; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C1D1B1F24813 for ; Tue, 30 Apr 2024 21:05:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0634E1A38C3; Tue, 30 Apr 2024 21:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="LlsnbLmv" Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BC6179B2 for ; Tue, 30 Apr 2024 21:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.228.157.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714511112; cv=none; b=sXv7sapcqExOL1d03gJkR3jOQ2+ADBfColcN/UEGLBh4oiVXUiDJxF/P6jAtIu04c8YZFVM7zXmL00CmBnsyRnv+JddtXGT2ruCn2LEJCOtmCQOdoTIimG40XSsqQW5G5xuc2sjrOmHRHDiqq9q/chaSdi19xxq30ujLOOunvMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714511112; c=relaxed/simple; bh=69PlvG7KIdje+L1fHWnUiXZTx3lV8LBQthCM8cJYhAE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Hdb1JIdhVrtJHW8MUhMMdGd2ZDsC31IjPQDaoQTc+IBfA945Y+VQ0Xei8UvoMXdBS9dXEqCEp6KQZlI3ZcaPgSK5F4N+VwDZyzWr3UsS17RP9+vuLGVLk7iRCMYW8+FfqGa/vfcYhB7obiyjebJeDa5rY3NTHXof2TjSAj2X0zQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=LlsnbLmv; arc=none smtp.client-ip=173.228.157.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id C1AF52219B; Tue, 30 Apr 2024 17:05:10 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=69PlvG7KIdje+L1fHWnUiXZTx3lV8LBQthCM8c JYhAE=; b=LlsnbLmvnI27XpFgNCmX8HmQ41IRQL7oIsrCr8W8OZ2sryPr1AVOHg TZKMmuDJTwRSgsW3Lef63qbz23xKxkpApdm4v4qugzKq6lRPT+PflGQIXKMQrVxR n92bOWpHyYloRWkwL99ugH/wBeAIUefDgvbzHQsMTa1LpiJB4QWuc= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id BAF9E2219A; Tue, 30 Apr 2024 17:05:10 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.120.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 92DD722198; Tue, 30 Apr 2024 17:05:05 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Josh Steadmon Cc: git@vger.kernel.org, peff@peff.net Subject: Re: [PATCH v5 6/7] t/Makefile: run unit tests alongside shell tests In-Reply-To: (Josh Steadmon's message of "Tue, 30 Apr 2024 12:55:56 -0700") References: Date: Tue, 30 Apr 2024 14:05:03 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 51A472F6-0735-11EF-BE79-A19503B9AAD1-77302942!pb-smtp21.pobox.com Josh Steadmon writes: > +# A simple wrapper to run shell tests via TEST_SHELL_PATH, > +# or exec unit tests directly. > + > +case "$1" in > +*.sh) > + if test -z "${TEST_SHELL_PATH+set}" > + then > + echo >&2 "ERROR: TEST_SHELL_PATH is empty or not set" > + exit 1 > + fi > + exec ${TEST_SHELL_PATH} "$@" You want to be prepared for a path like "//C/My Programs/bash". exec "$TEST_SHELL_PATH" "$@" > + ;; > +*) > + exec "$@" > + ;; > +esac