From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Marc Branchaud <marcnarc@xiplink.com>,
Stephan Beyer <s-beyer@gmx.net>, git <git@vger.kernel.org>
Subject: Re: [RFC] stash --continue
Date: Wed, 18 Jan 2017 11:10:09 -0800 [thread overview]
Message-ID: <xmqqk29s9oby.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701181725130.3469@virtualbox> (Johannes Schindelin's message of "Wed, 18 Jan 2017 17:34:58 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> > More like "git stash pop --continue". Without the "pop" command, it
>> > does not make too much sense.
>>
>> Why not? git should be able to remember what stash command created the
>> conflict. Why should I have to? Maybe the fire alarm goes off right when I
>> run the stash command, and by the time I get back to it I can't remember
>> which operation I did. It would be nice to be able to tell git to "just
>> finish off (or abort) the stash operation, whatever it was".
>
> That reeks of a big potential for confusion.
Yup. I agree everything you said in the message I am responding
to. Marc's argument will inevitably lead to: It should be
sufficient to say "git --continue", as Git should remember
everything for me. I do not think we want to go there.
next prev parent reply other threads:[~2017-01-18 19:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 23:56 [RFC] stash --continue Stephan Beyer
2017-01-16 3:59 ` Jacob Keller
2017-01-16 10:54 ` Johannes Schindelin
2017-01-18 15:41 ` Marc Branchaud
2017-01-18 16:34 ` Johannes Schindelin
2017-01-18 18:44 ` Marc Branchaud
2017-01-18 19:35 ` Samuel Lijin
2017-01-19 15:49 ` Johannes Schindelin
2017-01-19 18:38 ` Marc Branchaud
2017-01-19 21:30 ` Johannes Schindelin
2017-01-20 15:19 ` Marc Branchaud
2017-01-20 15:27 ` Johannes Schindelin
2017-01-18 19:10 ` Junio C Hamano [this message]
2017-01-18 19:20 ` Stephan Beyer
2017-01-19 15:54 ` Johannes Schindelin
2017-01-17 20:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk29s9oby.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).