git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, benpeart@microsoft.com,
	christian.couder@gmail.com, larsxschneider@gmail.com
Subject: Re: [PATCH v1 2/3] sub-process: refactor the filter process code into a reusable module
Date: Wed, 22 Mar 2017 23:16:37 -0700	[thread overview]
Message-ID: <xmqqk27gfrga.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170322165220.5660-3-benpeart@microsoft.com> (Ben Peart's message of "Wed, 22 Mar 2017 12:52:19 -0400")

Ben Peart <peartben@gmail.com> writes:

> This code is refactored from:
>
> 	Commit edcc85814c ("convert: add filter.<driver>.process option", 2016-10-16)
> 	keeps the external process running and processes all commands

I am afraid that this organization of the patch series is making it
harder than necessary to review, by duplicating the same code first
_WITH_ renaming of symbols, etc., in this step and then updaing the
original callers while removing the now-stale original callee
implementation in a separate next step.

Would it perhaps make it clearer to understand what is going on if
you instead started to update the code in convert.c in place to make
it more suitable fro reuse as the patch title advertises, and then
move the resulting cleaned-up code to a separate file, I wonder.


  reply	other threads:[~2017-03-23  7:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 16:52 [PATCH v1 0/3] Add support for downloading blobs on demand Ben Peart
2017-03-22 16:52 ` [PATCH v1 1/3] pkt-line: add packet_write_list_gently() Ben Peart
2017-03-22 20:21   ` Junio C Hamano
2017-03-24 12:34     ` Ben Peart
2017-03-22 16:52 ` [PATCH v1 2/3] sub-process: refactor the filter process code into a reusable module Ben Peart
2017-03-23  6:16   ` Junio C Hamano [this message]
2017-03-24 12:39     ` Ben Peart
2017-03-24 16:10       ` Junio C Hamano
2017-03-24 17:15         ` Junio C Hamano
2017-03-27 22:04           ` Ben Peart
2017-03-22 16:52 ` [PATCH v1 3/3] convert: use new sub-process module for filter processes Ben Peart
2017-03-25 11:59 ` [PATCH v1 0/3] Add support for downloading blobs on demand Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk27gfrga.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=benpeart@microsoft.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=peartben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).