From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Jeff King <peff@peff.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] t1404: add a bunch of tests of D/F conflicts
Date: Sun, 29 Oct 2017 09:05:44 +0900 [thread overview]
Message-ID: <xmqqk1zebyxz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171028164249.ufro5weobwadfonv@genre.crustytoothpaste.net> (brian m. carlson's message of "Sat, 28 Oct 2017 16:42:49 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> There is discussion in the Austin Group issue tracker about adding this
> feature to POSIX, but it's gotten bogged down over lexical versus
> dynamic scoping. Everyone agrees that it's a desirable feature, though.
> ...
In short, unless you are a binary packager on a platform whose
native shell is ksh and who refuses to depend on tools that are not
default/native on the platform, you'd be OK?
> I'd recommend an explicit test for this. It's much easier to track down
> that way than seeing other failure scenarios. People will also usually
> complain about failing tests.
Hopefully.
Starting from an explicit test, gradually using more "local" in
tests that cover more important parts of the system, and then start
using "local" as appropriate in the main tools would be a good way
forward.
By that time, we might have a lot less scripted Porcelains, though
;-)
next prev parent reply other threads:[~2017-10-29 0:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 15:16 [PATCH 0/2] Fix an error-handling path when locking refs Michael Haggerty
2017-10-24 15:16 ` [PATCH 1/2] t1404: add a bunch of tests of D/F conflicts Michael Haggerty
2017-10-24 16:19 ` Eric Sunshine
2017-10-24 19:46 ` Jeff King
2017-10-25 8:03 ` Michael Haggerty
2017-10-25 8:23 ` Michael Haggerty
2017-10-26 6:32 ` Jeff King
2017-10-28 16:42 ` brian m. carlson
2017-10-29 0:05 ` Junio C Hamano [this message]
2017-10-29 16:12 ` brian m. carlson
2017-10-24 15:16 ` [PATCH 2/2] files_transaction_prepare(): fix handling of ref lock failure Michael Haggerty
2017-10-24 19:49 ` Jeff King
2017-10-25 2:29 ` Junio C Hamano
2017-10-24 19:45 ` [PATCH 0/2] Fix an error-handling path when locking refs Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1zebyxz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).