git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Lars Schneider <lars.schneider@autodesk.com>,
	Git List <git@vger.kernel.org>,
	Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v2] launch_editor(): indicate that Git waits for user input
Date: Fri, 24 Nov 2017 15:38:40 +0900	[thread overview]
Message-ID: <xmqqk1ygnpu7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <998E3A52-C710-447A-82A3-50C58354CC31@gmail.com> (Lars Schneider's message of "Wed, 22 Nov 2017 17:55:29 +0100")

Lars Schneider <larsxschneider@gmail.com> writes:

>> Of course it is possible, if you really wanted to.  The code knows
>> if it gave the "we launched and waiting for you" notice, so it can
>> maintain not just one (i.e. "how I close the notice?") but another
>> one (i.e. "how I do so upon an error?") and use it in the error
>> codepath.
>
> I think a newline makes sense. I'll look into this for v3.

As this is an error codepath, I am OK to waste one more line with a
line break after the "we launched and are waiting..." message, but
with a shorter "we are waiting..." message, I do not know if it is
bad enough to have these two on the same line, so I am on the fence.

  parent reply	other threads:[~2017-11-24  6:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 13:51 [PATCH v2] launch_editor(): indicate that Git waits for user input lars.schneider
2017-11-17 18:40 ` Junio C Hamano
2017-11-22 16:47   ` Lars Schneider
2017-11-17 19:41 ` Eric Sunshine
2017-11-18  1:40   ` Junio C Hamano
2017-11-19 17:49     ` Kaartic Sivaraam
2017-11-20  0:11       ` Junio C Hamano
2017-11-22 16:55         ` Lars Schneider
2017-11-22 17:58           ` Kaartic Sivaraam
2017-11-24  6:38           ` Junio C Hamano [this message]
2017-11-22 16:53   ` Lars Schneider
2017-11-22 17:33     ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk1ygnpu7.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=lars.schneider@autodesk.com \
    --cc=larsxschneider@gmail.com \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).