* [PATCH] completion: complete tags with git tag --delete/--verify
@ 2018-03-18 4:01 Todd Zullinger
2018-03-19 16:55 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Todd Zullinger @ 2018-03-18 4:01 UTC (permalink / raw)
To: git; +Cc: Nguyễn Thái Ngọc Duy, SZEDER Gábor
Completion of tag names has worked for the short -d/-v options since
88e21dc746 ("Teach bash about completing arguments for git-tag",
2007-08-31). The long options were not added to "git tag" until many
years later, in c97eff5a95 ("git-tag: introduce long forms for the
options", 2011-08-28).
Extend tag name completion to --delete/--verify.
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6da95b8095..c7957f0a90 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2967,7 +2967,7 @@ _git_tag ()
while [ $c -lt $cword ]; do
i="${words[c]}"
case "$i" in
- -d|-v)
+ -d|--delete|-v|--verify)
__gitcomp_direct "$(__git_tags "" "$cur" " ")"
return
;;
--
2.17.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] completion: complete tags with git tag --delete/--verify
2018-03-18 4:01 [PATCH] completion: complete tags with git tag --delete/--verify Todd Zullinger
@ 2018-03-19 16:55 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-03-19 16:55 UTC (permalink / raw)
To: Todd Zullinger
Cc: git, Nguyễn Thái Ngọc Duy, SZEDER Gábor
Todd Zullinger <tmz@pobox.com> writes:
> Completion of tag names has worked for the short -d/-v options since
> 88e21dc746 ("Teach bash about completing arguments for git-tag",
> 2007-08-31). The long options were not added to "git tag" until many
> years later, in c97eff5a95 ("git-tag: introduce long forms for the
> options", 2011-08-28).
>
> Extend tag name completion to --delete/--verify.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
Thanks, makes sense.
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 6da95b8095..c7957f0a90 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2967,7 +2967,7 @@ _git_tag ()
> while [ $c -lt $cword ]; do
> i="${words[c]}"
> case "$i" in
> - -d|-v)
> + -d|--delete|-v|--verify)
> __gitcomp_direct "$(__git_tags "" "$cur" " ")"
> return
> ;;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-18 4:01 [PATCH] completion: complete tags with git tag --delete/--verify Todd Zullinger
2018-03-19 16:55 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).