From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] fsckObjects tests: show how v2.17.1 can exploit downstream
Date: Wed, 30 May 2018 10:32:19 +0900 [thread overview]
Message-ID: <xmqqk1rmexng.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180529212458.GC7964@sigill.intra.peff.net> (Jeff King's message of "Tue, 29 May 2018 17:24:58 -0400")
Jeff King <peff@peff.net> writes:
>> It's worth testing for this explicitly. So let's amend the tests added
>> in 73c3f0f704 ("index-pack: check .gitmodules files with --strict",
>> 2018-05-04) to show how this can result in a v2.17.1 client passing
>> along the evil objects.
>
> I'm not sure what testing this buys us. If it stopped passing them
> along, would we consider that a regression? This seems more like a
> documentation issue than something that needs to be tested.
I tend to agree. The recommendation of the release notes is about
protecting the place downstream would pull from, by telling Git to
vet the pushes into that place and that is why receive.fsckObjects
is mentioned there. Nobody sane would expect receive.fsckObjects to
do anything when that central place fetches from elsewhere, and I am
not sure what additional value it buys us(over the tests we already
have) to test that diabled transfer.fsckObjects are truly disabled.
If we want to also encourage people to vet their own "fetches", I am
not against extending documentation. It just is different from "we
extended the mechanism to help server side protect their clients"
that was the focus of (updated, relative to what is in the tarball)
the description in the release notes.
Thanks.
next prev parent reply other threads:[~2018-05-30 1:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 21:19 [PATCH] fsckObjects tests: show how v2.17.1 can exploit downstream Ævar Arnfjörð Bjarmason
2018-05-29 21:24 ` Jeff King
2018-05-29 21:59 ` Ævar Arnfjörð Bjarmason
2018-05-30 2:57 ` Junio C Hamano
2018-05-31 5:54 ` Jeff King
2018-05-31 6:52 ` Ævar Arnfjörð Bjarmason
2018-05-30 1:32 ` Junio C Hamano [this message]
2018-05-31 6:02 ` Jeff King
2018-06-01 1:42 ` Junio C Hamano
2018-06-01 5:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1rmexng.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).