From: Junio C Hamano <gitster@pobox.com>
To: Masaya Suzuki <masayasuzuki@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin/send-pack: populate the default configs
Date: Tue, 12 Jun 2018 10:38:42 -0700 [thread overview]
Message-ID: <xmqqk1r3aorh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180612172623.165420-1-masayasuzuki@google.com> (Masaya Suzuki's message of "Tue, 12 Jun 2018 10:26:23 -0700")
Masaya Suzuki <masayasuzuki@google.com> writes:
> builtin/send-pack didn't call git_default_config, and because of this
> git push --signed didn't respect the username and email in gitconfig in
> the HTTP transport.
>
> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
> ---
> builtin/send-pack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Makes sense. I wonder if this was deliberate (i.e. we had some
reason not wanting to be affected by some _other_ configuration
items and refraining from doing the default-config was the way to
implement it), but I do not think of a reason offhand.
Will queue. Thanks.
>
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 4923b1058..42fd8d1a3 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -121,7 +121,7 @@ static int send_pack_config(const char *k, const char *v, void *cb)
> }
> }
> }
> - return 0;
> + return git_default_config(k, v, cb);
> }
>
> int cmd_send_pack(int argc, const char **argv, const char *prefix)
next prev parent reply other threads:[~2018-06-12 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 17:26 [PATCH] builtin/send-pack: populate the default configs Masaya Suzuki
2018-06-12 17:38 ` Junio C Hamano [this message]
2018-06-12 17:53 ` [PATCH] builtin/send-pack: report gpg config errors Stefan Beller
2018-06-12 17:55 ` Eric Sunshine
2018-06-12 18:07 ` Jonathan Nieder
2018-06-12 18:19 ` Stefan Beller
2018-06-12 18:16 ` [PATCH] builtin/send-pack: populate the default configs Jonathan Nieder
2018-06-12 18:22 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1r3aorh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).