git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeremy Linton <lintonrjeremy@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	Git List <git@vger.kernel.org>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2] packfile: Correct zlib buffer handling
Date: Wed, 13 Jun 2018 14:56:35 -0700	[thread overview]
Message-ID: <xmqqk1r25p0s.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAEFTgix0pasg38cb2_qrN+iPgVuq-BX9b7q+qC5Ep9iFbS=Szg@mail.gmail.com> (Jeremy Linton's message of "Wed, 13 Jun 2018 16:48:12 -0500")

Jeremy Linton <lintonrjeremy@gmail.com> writes:

>> Here is what I tentatively came up with.
>>
>> -- >8 --
>> From: Jeremy Linton <lintonrjeremy@gmail.com>
>> Date: Wed, 13 Jun 2018 09:22:07 -0500
>> Subject: [PATCH] packfile: correct zlib buffer handling
>>
>> The buffer being passed to zlib includes a NUL terminator that git
>> ...
>> +
>>         return buffer;
>>  }
>>
>> --
>> 2.18.0-rc1-1-g6f333ff2fb
>
> This is all fine with me, the original comment was an attempt to
> indicate that the original null may not have been there anymore too..
>
> Shall I resubmit it as above, or can it be picked up like this?

If you are happy with what you saw above, I can just make it no
longer "tentative" and use it as-is, which would save time for both
of us ;-)

Thanks.

      reply	other threads:[~2018-06-13 21:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 14:22 [PATCH v2] packfile: Correct zlib buffer handling Jeremy Linton
2018-06-13 17:21 ` Eric Sunshine
2018-06-13 18:32   ` Junio C Hamano
2018-06-13 18:40     ` Eric Sunshine
2018-06-13 18:38   ` Junio C Hamano
2018-06-13 21:48     ` Jeremy Linton
2018-06-13 21:56       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk1r25p0s.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=lintonrjeremy@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).