git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet
Date: Mon, 04 Feb 2019 10:26:29 -0800	[thread overview]
Message-ID: <xmqqk1ifv296.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190202163421.19686-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Sat, 2 Feb 2019 17:34:21 +0100")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Before installing the necessary dependencies, our OSX build jobs run
> 'brew update --quiet'.  This is problematic for two reasons:
>
>   - This '--quiet' flag apparently broke overnight, resulting in
>     errored builds:
> ...
>     I belive that this breakage will be noticed and fixed soon-ish, so
>     we could probably just wait a bit for this issue to solve itself,

Yuck.  Well, an external influence that can break the automated
build job overnight should be capable of fixing it overnight ;-)

>     but:
>
>   - 'brew update --quiet' wasn't really quiet in the first place, as
>     it listed over about 2000 lines worth of available packages that
>     we absolutely don't care about, see e.g. one of the latest
>     'master' builds:
>
>       https://travis-ci.org/git/git/jobs/486134962#L113
>
> So drop this '--quiet' option and redirect 'brew update's standard
> output to /dev/null to make it really quiet, thereby making the OSX
> builds work again despite the above mentioned breakage.

Sounds good.

>     There is no conflict with Dscho's Azure Pipelines patch series; the
>     patch contexts overlap a bit, but the auto-merging results look good
>     to me.

Thanks for extra careful.

If this is truly urgent, I could merge this to 'maint' and merge the
result upwards to 'pu' and it would hide the issue on my four
integration branches.  But one thing that makes me wonder is if we
can (or want to) do anything to help other people who test build
with pull requests.  I guess they need to rebase on top of whatever
commit that has this fix?  That sounds more like a tail wagging a
dog, though.  I dunno.

>  ci/install-dependencies.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 06c3546e1e..5968efdbbe 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -34,7 +34,7 @@ linux-clang|linux-gcc)
>  	popd
>  	;;
>  osx-clang|osx-gcc)
> -	brew update --quiet
> +	brew update >/dev/null
>  	# Uncomment this if you want to run perf tests:
>  	# brew install gnu-time
>  	brew install git-lfs gettext

  parent reply	other threads:[~2019-02-04 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 16:34 [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet SZEDER Gábor
2019-02-04  9:49 ` Johannes Schindelin
2019-02-04 19:38   ` SZEDER Gábor
2019-02-05 11:31     ` Johannes Schindelin
2019-02-04 18:26 ` Junio C Hamano [this message]
2019-02-04 19:38   ` SZEDER Gábor
2019-02-05 11:41     ` Johannes Schindelin
2019-02-05 17:53       ` Junio C Hamano
2019-02-06 11:33         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk1ifv296.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).