From: Junio C Hamano <gitster@pobox.com>
To: anng.sw@gmail.com
Cc: git@vger.kernel.org, eantoranz@gmail.com, Andrew Ng <andrew.ng@sony.com>
Subject: Re: [PATCH] merge: optimization to skip evaluate_result for single strategy
Date: Mon, 18 May 2020 10:23:34 -0700 [thread overview]
Message-ID: <xmqqk11940o9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200518153613.17497-1-anng.sw@gmail.com> (anng sw's message of "Mon, 18 May 2020 16:36:13 +0100")
anng.sw@gmail.com writes:
> From: Andrew Ng <andrew.ng@sony.com>
>
> For a merge with a single strategy, the result of evaluate_result() is
> effectively not used and therefore is not needed, so avoid altogether.
Excellent observation.
> On Windows, this optimization can half the time required to perform a
s/half/halve/
> recursive merge of a single commit with the LLVM repo.
>
> Signed-off-by: Andrew Ng <andrew.ng@sony.com>
> ---
> builtin/merge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/merge.c b/builtin/merge.c
> index ca6a5dc4bf..7da707bf55 100644
> --- a/builtin/merge.c
> +++ b/builtin/merge.c
> @@ -1656,7 +1656,7 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
> }
> merge_was_ok = 1;
> }
> - cnt = evaluate_result();
> + cnt = (use_strategies_nr > 1) ? evaluate_result() : 0;
As best_cnt is initialized to (-1), any value would trigger the
logic to nominate the current one as "best so far", and 0 is just as
good as it gets ;-) And we'll finish the loop soon after doing so.
Looks good.
> if (best_cnt <= 0 || cnt <= best_cnt) {
> best_strategy = use_strategies[i]->name;
> best_cnt = cnt;
next prev parent reply other threads:[~2020-05-18 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 15:36 [PATCH] merge: optimization to skip evaluate_result for single strategy anng.sw
2020-05-18 17:23 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-19 13:05 anng.sw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk11940o9.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=andrew.ng@sony.com \
--cc=anng.sw@gmail.com \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).