From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2020, #06; Thu, 30)
Date: Thu, 30 Jul 2020 18:27:41 -0700 [thread overview]
Message-ID: <xmqqk0yk5v8y.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200731010307.GE240563@coredump.intra.peff.net> (Jeff King's message of "Thu, 30 Jul 2020 21:03:07 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Jul 30, 2020 at 04:47:04PM -0700, Junio C Hamano wrote:
>
>> * jk/strvec (2020-07-28) 11 commits
>> - strvec: rename struct fields
>> - strvec: drop argv_array compatibility layer
>> - strvec: update documention to avoid argv_array
>> - strvec: fix indentation in renamed calls
>> - strvec: convert remaining callers away from argv_array name
>> - strvec: convert more callers away from argv_array name
>> - strvec: convert builtin/ callers away from argv_array name
>> - quote: rename sq_dequote_to_argv_array to mention strvec
>> - strvec: rename files from argv-array to strvec
>> - argv-array: rename to strvec
>> - argv-array: use size_t for count and alloc
>>
>> The argv_array API is useful for not just managing argv but any
>> "vector" (NULL-terminated array) of strings, and has seen adoption
>> to a certain degree. It has been renamed to "strvec" to reduce the
>> barrier to adoption.
>>
>> Will merge to 'next'.
>
> Do we want to do the s/items/v/ thing before it gets merged to next?
I do want to get rid of that items[] thing. An array with a plural
name that is accessed one element at a time a lot more often than
referred to as a collection as a whole is simply stupid.
> I already posted a replacement top patch in the thread:
>
> https://lore.kernel.org/git/20200729003720.GA1653374@coredump.intra.peff.net/
>
> and I don't think anything else needed a re-roll.
I missed that one. Will replace and adjust the conflict resolution
but I'll have to wait for my attention/focus to be recharged before
doing so.
Thanks for reminding.
prev parent reply other threads:[~2020-07-31 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 23:47 What's cooking in git.git (Jul 2020, #06; Thu, 30) Junio C Hamano
2020-07-31 1:03 ` Jeff King
2020-07-31 1:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0yk5v8y.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).