From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 32DAC1F670 for ; Thu, 19 Nov 2020 19:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728008AbgKSTfW (ORCPT ); Thu, 19 Nov 2020 14:35:22 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:55699 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727192AbgKSTfW (ORCPT ); Thu, 19 Nov 2020 14:35:22 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 867CB988E4; Thu, 19 Nov 2020 14:35:19 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=5mMDs2BRLGmU n3GKlsXM9wZxewU=; b=EcIorMTX4sE8ib27iQx7rkaehOsz24H6Mnv8Ab6ihpyZ h7tG2vu9kmfkVJvUvMMNnKhBjVAATGEjEU0/8RHoHRHog11sBeKMp7rn7OXwJuCh rSflqCWBOy6j31jKF4k5sdxXsnPDRSB6jhjOZ/i51QJpEbUrC1My2THppIWe5CM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=vRDKOH ALC4HgpYaTjZRHkNmXVibrYgV19bzyyXadvRg8Xmfp90mVyDqPdooq2e4ujdpKPm 3kaQCTTFq+YTrjGB5DvYhUdm7NrxCAvVivqwI6oelhtyrrLSXQkqrVNVDHJLNOob 5IjCpA/n1NVtb1fmSsjtAmc4lnV/Amqw85XDg= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 7DD57988E3; Thu, 19 Nov 2020 14:35:19 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 05ECA988E2; Thu, 19 Nov 2020 14:35:19 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Jeff King , git@vger.kernel.org, Theodore Ts'o , Don Goodman-Wilson , "brian m. carlson" , Felipe Contreras Subject: Re: [RFC/PATCH] tests: support testing with an arbitrary default branch (sort of) References: <20201113161320.16458-1-avarab@gmail.com> <20201113191418.GA764688@coredump.intra.peff.net> <87h7psg6lz.fsf@evledraar.gmail.com> <87ima2rdsm.fsf@evledraar.gmail.com> Date: Thu, 19 Nov 2020 11:35:18 -0800 In-Reply-To: (Johannes Schindelin's message of "Thu, 19 Nov 2020 10:32:30 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 5B55812C-2A9E-11EB-8C2A-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: > Hi Junio & =C3=86var, > > On Wed, 18 Nov 2020, Junio C Hamano wrote: > >> =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: >> >> > P.S.: Shouldn't the pull patch in d18c950a69f be using the advice >> > facility, not warning()? >> >> I think warning() is the right thing here, as it is self squelching. >> Setting pull.rebase (even to 'false') is sufficient---there is no >> need to set advise.setpullrebase to 'false' on top. > > Right. The only reason to use `advise()` would be to allow users to > squelch the warning by setting `advice.*`. > > On the other hand, warnings are not colored, but advice messages are. > > And now I realize that the same holds for `init.defaultBranch`: it is a= lso > self-squelching. And it also might benefit from the coloring to make it > stand out a bit. > > Thoughts? I do not see colors well. You'll always get "find some other way to make it stand out more to those like us---if you canhdo so without colors, that would be ideal" from me, so please don't ask me to vote for more colors.