git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t: use configured TAR instead of tar
Date: Sat, 22 May 2021 15:46:45 +0900	[thread overview]
Message-ID: <xmqqk0nrqn8q.fsf@gitster.g> (raw)
In-Reply-To: <20210522062815.17083-1-congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Sat, 22 May 2021 13:28:15 +0700")

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

> Despite that tar is available everywhere, it's not required by POSIX.
> And, we're allow users to specify which tar they want to use in Makefile

s/we're/we/;

> knobs, and we prefer GNU tar in autotools script.

The last part I didn't know about---it is sad if autotools require
use of gtar (but since use of autoconf and autotools is not required
to build Git, I do not deeply care ;-)).

> In our testsuite, 7 out of 9 tar-required-tests use "$TAR", the other
> two use "tar".
>
> Let's change the remaining two tests to "$TAR".

Nice.

  reply	other threads:[~2021-05-22  6:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22  6:28 [PATCH] t: use configured TAR instead of tar Đoàn Trần Công Danh
2021-05-22  6:46 ` Junio C Hamano [this message]
2021-05-22 18:58   ` brian m. carlson
2021-05-22  7:10 ` [PATCH v2] " Đoàn Trần Công Danh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0nrqn8q.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).