From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Jeff King <peff@peff.net>,
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] rebase, cherry-pick, revert: only run from toplevel
Date: Tue, 31 Aug 2021 22:29:10 -0700 [thread overview]
Message-ID: <xmqqk0k0sw2h.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFmU+RaAjq4_0-PSfRgH1Jc63nN0fMuDWk2+iDbdz7CCA@mail.gmail.com> (Elijah Newren's message of "Tue, 31 Aug 2021 13:14:55 -0700")
Elijah Newren <newren@gmail.com> writes:
> Ooh, this sounds intriguing to me...but what if we changed that rule
> slightly and just decided to never make the cwd go away? Currently,
> the checkout code removes directories if they have no tracked or
> untracked or ignored files left, i.e. if they're empty. What if we
> decide to only have remove_scheduled_dirs() remove directories that
> are empty AND they are not the current working directory?
Is that generally doable? What would we do when the directory the
subcommand was started from (or one of its parent directories) is
not just missing but has to be a file in the revision the subcommand
is trying to checkout?
next prev parent reply other threads:[~2021-09-01 5:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 3:03 [PATCH] rebase, cherry-pick, revert: only run from toplevel Elijah Newren via GitGitGadget
2021-08-31 3:05 ` Elijah Newren
2021-08-31 5:55 ` Johannes Sixt
2021-08-31 7:01 ` Jeff King
2021-08-31 20:14 ` Elijah Newren
2021-09-01 2:55 ` Taylor Blau
2021-09-01 4:43 ` Elijah Newren
2021-09-01 4:59 ` Taylor Blau
2021-09-01 6:48 ` Elijah Newren
2021-09-01 5:29 ` Junio C Hamano [this message]
2021-09-01 6:08 ` Elijah Newren
2021-09-01 6:30 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2021-11-26 7:31 Leon Dingman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0k0sw2h.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).