From: Junio C Hamano <gitster@pobox.com>
To: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwenn@gmail.com>
Subject: Re: [PATCH 0/3] preliminary fixes for reftable support
Date: Thu, 23 Dec 2021 12:27:55 -0800 [thread overview]
Message-ID: <xmqqk0fv83sk.fsf@gitster.g> (raw)
In-Reply-To: <pull.1164.git.git.1640287790.gitgitgadget@gmail.com> (Han-Wen Nienhuys via GitGitGadget's message of "Thu, 23 Dec 2021 19:29:47 +0000")
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
> these two commits to the reftable library prepare for making 2 tests in the
> test suite pass in my pending changes for reftable support.
Welcome again to our "we cannot count to three" club.
> This series was built against 'master'. It also has a fix for a fd leak (>=
> 0 vs > 0), which is part of my reftable-coverity fixes topic.
What is going on here? We have the same fix in two series? Are
these two series meant to be applied, or is this a beginning of
splitting and resubmitting the other larger series into smaller
chunks?
I am not opposed to having two identical fixes to a high priority
problem, one in a long series that may take longer to graduate and
the other one in a short series that is trivial to verify. I am not
opposed to retract a longer series and trickle a number of series'
that replace it, either. I just wanted to know what is happening
here.
Thanks.
> Han-Wen Nienhuys (3):
> reftable: fix typo in header
> reftable: signal overflow
> reftable: support preset file mode for writing
>
> reftable/block.h | 2 +-
> reftable/error.c | 2 ++
> reftable/readwrite_test.c | 35 +++++++++++++++++++++++++++++++++++
> reftable/reftable-error.h | 4 ++++
> reftable/reftable-writer.h | 3 +++
> reftable/stack.c | 30 ++++++++++++++++++++++++------
> reftable/stack_test.c | 33 +++++++++++++++++++++++++++++----
> reftable/writer.c | 3 +++
> 8 files changed, 101 insertions(+), 11 deletions(-)
>
>
> base-commit: fae76fe5da3df25d752f2251b7ccda3f62813aa9
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1164%2Fhanwen%2Freftable-features-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1164/hanwen/reftable-features-v1
> Pull-Request: https://github.com/git/git/pull/1164
next prev parent reply other threads:[~2021-12-23 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 19:29 [PATCH 0/3] preliminary fixes for reftable support Han-Wen Nienhuys via GitGitGadget
2021-12-23 19:29 ` [PATCH 1/3] reftable: fix typo in header Han-Wen Nienhuys via GitGitGadget
2021-12-23 19:29 ` [PATCH 2/3] reftable: signal overflow Han-Wen Nienhuys via GitGitGadget
2021-12-23 19:29 ` [PATCH 3/3] reftable: support preset file mode for writing Han-Wen Nienhuys via GitGitGadget
2021-12-24 4:46 ` Junio C Hamano
2022-01-10 19:01 ` Han-Wen Nienhuys
2022-01-10 19:14 ` Junio C Hamano
2021-12-23 20:27 ` Junio C Hamano [this message]
2021-12-24 2:15 ` [PATCH 0/3] preliminary fixes for reftable support Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0fv83sk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).