From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7FD621F8C4 for ; Mon, 14 Mar 2022 21:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245370AbiCNVsd (ORCPT ); Mon, 14 Mar 2022 17:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236193AbiCNVsc (ORCPT ); Mon, 14 Mar 2022 17:48:32 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00BCB3A5F7 for ; Mon, 14 Mar 2022 14:47:21 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 52CDA11225D; Mon, 14 Mar 2022 17:47:21 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=9YDCHnOvTU1H1VbA3fyibV1YYIW2zaBzjTjMkD xkh6Q=; b=IdIFjiXiV7v5B4+klM3zbeEdm6KsSixtxKEu9n9BzXstN4pB0u+nol vPYdpouLyAPP/D5VvnOSAfmoNO3LoOQh+JO0AeylTaUBaptedjdGbXftg7RxeS2Q uzDVmLH+gCerlz55JAUCrB2EQjDFQ1ETuGSjvt8yq0z6WlK0a64Mo= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 48A3E11225C; Mon, 14 Mar 2022 17:47:21 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id AD34A11225A; Mon, 14 Mar 2022 17:47:20 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: John Cai via GitGitGadget , git@vger.kernel.org, John Cai Subject: Re: [PATCH v2 1/2] rebase: use test_commit helper in setup References: <4072d712-4138-6cf0-e0e0-5a3303ce010a@gmail.com> Date: Mon, 14 Mar 2022 21:47:18 +0000 In-Reply-To: <4072d712-4138-6cf0-e0e0-5a3303ce010a@gmail.com> (Phillip Wood's message of "Mon, 14 Mar 2022 10:52:34 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 534E3FCA-A3E0-11EC-A284-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Phillip Wood writes: > On 13/03/2022 07:50, Junio C Hamano wrote: >> "John Cai via GitGitGadget" writes: >> >>> From: John Cai >>> >>> To prepare for the next commit that will test rebase with oids instead >>> of branch names, update the rebase setup test to add a couple of tags we >>> can use. This uses the test_commit helper so we can replace some lines >>> that add a commit manually. >> OK. >> >>> test_expect_success 'prepare repository with topic branches' ' >>> - git config core.logAllRefUpdates true && >> This lossage is not explained. I do not know if we actually make >> use of the reflog in the tests, though. > > It is the default these days so we don't need to waste a process > setting it here. I said "not explained" in the log message. I didn't ask anybody to explain it to me or to readers on the list. Thanks.