From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 83AD51F51E for ; Wed, 28 Sep 2022 18:04:40 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="iKU2fSCE"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234569AbiI1SEb (ORCPT ); Wed, 28 Sep 2022 14:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234661AbiI1SES (ORCPT ); Wed, 28 Sep 2022 14:04:18 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5412510253D for ; Wed, 28 Sep 2022 11:04:12 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9C50B145D97; Wed, 28 Sep 2022 14:04:11 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=TyFpnwdjIqQi 8+8/7t2ioRMRHLufNsfBvQJqqC9c+bc=; b=iKU2fSCEWS6GnAr8wOz07pzfwOy9 zcqTLUAHagG0UYKpqr9k4V9BCAiYkkF0idb27MnLbDaFQk2vmv94qUIgiP1OjaAL nkZmHerBY25Haglg5TGOr2kbGj6utf2GhCpCBmbLI52IAkChKALK+oHktGs7m6EB y5OJ/4ZYa+0MllY= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 921B7145D96; Wed, 28 Sep 2022 14:04:11 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id EA545145D8E; Wed, 28 Sep 2022 14:04:10 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Victoria Dye , Taylor Blau , Emily Shaffer , Jonathan Nieder , John Cai Subject: Re: [PATCH v2 00/35] doc/UX: make txt & -h output more consistent References: Date: Wed, 28 Sep 2022 11:04:09 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 28 Sep 2022 10:38:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: F42F97A0-3F57-11ED-A0F2-307A8E0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Victoria: I decided not to go for your suggestion of trimming this > series down in [1]. Reasons: > > * It would take me time I don't have to spend on this, as some of it > isn't easy to cleanly re-arrange. E.g. the later "make consistent" > commits rely on earlier whitespace/basic syntax fixes. A devil's advocate question. If even the original author feels it does not deserve his or her time to clean up the series, how does it possibly deserve reviewers' time to review such a series? > * A major advantage of reviewing this in one go is that the 34-35/35 > tests at the end are asserting everything that came before > it. Yes, but it does not assert anything about the other patches not doing unrelated things while at it. So tests cannot be blindly trusted (in other words you have to be also trustworthy, if the reviewers are expected to swallow this huge series uninspected). I'll give it a read-over when I find time. Thanks for working on it.