From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Jeff King" <peff@peff.net>, "Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] tree-walk: disallow overflowing modes
Date: Sun, 22 Jan 2023 08:36:12 -0800 [thread overview]
Message-ID: <xmqqk01esf0j.fsf@gitster.g> (raw)
In-Reply-To: <044bdc8f-fdc9-dfd2-6cbb-941513467524@web.de> ("René Scharfe"'s message of "Sun, 22 Jan 2023 11:03:38 +0100")
René Scharfe <l.s.r@web.de> writes:
> We could be more strict and reject everything that oversteps
> S_IFMT|ALLPERMS, but the latter is not defined everywhere. But
> permission bits are well-known, so the magic number 07777 should be
> recognizable enough. Like this?
I do not quite see the reason why we want to be more strict than we
already are at this point in the code path. Stricter mode check in
reports FSCK_MSG_ZERO_PADDED_FILEMODE and FSCK_MSG_BAD_FILEMODE from
"fsck", which I think is probably sufficient.
Avoiding integer wraparound is a good idea, even if it were
impossible to induce misparsing of the tree data to lead to any
security issues, for the same reason why we check for zero padded
filemode, i.e. such a tree mode will allow the same tree object to
be given different object names.
Thanks.
next prev parent reply other threads:[~2023-01-22 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 9:36 [PATCH] tree-walk: disallow overflowing modes René Scharfe
2023-01-22 7:50 ` Jeff King
2023-01-22 10:03 ` René Scharfe
2023-01-22 16:36 ` Junio C Hamano [this message]
2023-01-22 22:02 ` Jeff King
2023-01-23 8:33 ` Ævar Arnfjörð Bjarmason
2023-01-24 18:53 ` René Scharfe
2023-01-24 20:44 ` Junio C Hamano
2023-01-26 11:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk01esf0j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).