From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] test: make SYMLINKS prerequisite more robust
Date: Fri, 10 Feb 2023 09:31:05 -0800 [thread overview]
Message-ID: <xmqqk00pjuli.fsf@gitster.g> (raw)
In-Reply-To: <xmqqbkm3ppn8.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 08 Feb 2023 17:56:59 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> I wonder if something like this is in order?
>>
>> I don't have much to contribute on that front, but this is really
>> missing some "why", this worked before, why is it failing now? Do we
>> have any idea.
>
> Your guess is as good as mine. I do not do Windows.
This morning, I notice that those CI jobs I ran last night that
failed with "whoa, windows tests are somehow reporting that symlinks
are available but not really" issue the patch in this thread were
attempting to address has passed even for branches like 'master' and
'next' that do not yet have it, and it seems to be because you
re-run these failed jobs.
Whatever magic you used to fix these failing tests, thanks.
Do you have an insight on why and how these were failing? The patch
in this thread was a band-aid without knowing why all of a sudden
"ln -s x y && test -h y" started passing (while compat/mingw.c still
says readlink() is not supported). If we know that such a breakage
is not expected, we can drop this workaroun, which would be great.
Thanks.
next prev parent reply other threads:[~2023-02-10 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 19:40 [PATCH] test: make SYMLINKS prerequisite more robust Junio C Hamano
2023-02-08 23:09 ` Ævar Arnfjörð Bjarmason
2023-02-09 1:56 ` Junio C Hamano
2023-02-09 2:15 ` Ævar Arnfjörð Bjarmason
2023-02-09 22:54 ` Junio C Hamano
2023-02-10 17:31 ` Junio C Hamano [this message]
2023-02-10 19:39 ` Ævar Arnfjörð Bjarmason
2023-02-13 9:12 ` Johannes Schindelin
2023-02-13 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk00pjuli.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).