From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "Alex Henrie" <alexhenrie24@gmail.com>,
"Heba Waly" <heba.waly@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Matheus Tavares" <matheus.tavb@gmail.com>
Subject: Re: [PATCH 0/2] advice: add diverging advice
Date: Wed, 08 Mar 2023 09:17:35 -0800 [thread overview]
Message-ID: <xmqqjzzrupqo.fsf@gitster.g> (raw)
In-Reply-To: <ZAix68A9e6RHz69y@nand.local> (Taylor Blau's message of "Wed, 8 Mar 2023 11:03:55 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> I don't think that splitting it into two separate patches was strictly
> necessary. If I were queuing, I'd probably squash the two together, ...
One advantage of sending a topic like this as two patches is that,
if the review discussion leads to a consensus that the new help
message should be given unconditionally to everybody, only [1/2] can
be queued while dropping [2/2]. But the point of advise() is to
serve as a training wheel that can be disabled by users who no
longer need it, so need for such a "flexibility" may not appear in
topics that add new advise() calls all that often, I would imagine.
I am willing to do the squashing on the receiving end. The effect
of two patches combined together is a good improvement, and the
proposed log message for the first one covers why we want to do both
of these two.
Thanks, both, for writing and reviewing.
next prev parent reply other threads:[~2023-03-08 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 2:48 [PATCH 0/2] advice: add diverging advice Felipe Contreras
2023-03-08 2:48 ` [PATCH 1/2] advice: add diverging advice for novices Felipe Contreras
2023-03-08 17:17 ` Junio C Hamano
2023-03-08 2:48 ` [PATCH 2/2] advice: make diverging advice configurable Felipe Contreras
2023-03-08 16:03 ` [PATCH 0/2] advice: add diverging advice Taylor Blau
2023-03-08 17:17 ` Junio C Hamano [this message]
2023-03-09 23:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzzrupqo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=heba.waly@gmail.com \
--cc=matheus.tavb@gmail.com \
--cc=me@ttaylorr.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).