From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: ** X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=2.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, LIST_MIRROR_RECEIVED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ABE751F406 for ; Tue, 17 Oct 2023 20:22:10 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=pDhJlDOu; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0BFBE1C20C4F for ; Tue, 17 Oct 2023 20:22:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E9C1043118; Tue, 17 Oct 2023 20:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="pDhJlDOu" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2BE430F9 for ; Tue, 17 Oct 2023 20:22:01 +0000 (UTC) Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A81F92 for ; Tue, 17 Oct 2023 13:22:00 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id BE54F2E0EC; Tue, 17 Oct 2023 16:21:59 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=YhRh7ePOmlDIVt4gYeo6Ysahgd2bAV8kU43IIL mNQFM=; b=pDhJlDOuiwn1HmY9HNZTlicS0CANcWWeS1/ZMAMH01TAGnVXAO2K/b 1Y4NSueMzZKkJdZqcbBraRhKuT+9Cr/A59qifsxkyktY0QCCGuPWU72mv29LV7EG vLg5V9WM0uPPQCUm3zEp6pOET4zGf3GhINRZZJjfOjoYm/tOuefbM= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id B65772E0EB; Tue, 17 Oct 2023 16:21:59 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.153.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 2FED92E0EA; Tue, 17 Oct 2023 16:21:56 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Dorcas Litunya Cc: christian.couder@gmail.com, git@vger.kernel.org Subject: Re: none In-Reply-To: (Dorcas Litunya's message of "Mon, 16 Oct 2023 21:43:20 +0300") References: Date: Tue, 17 Oct 2023 13:21:54 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D145AAFC-6D2A-11EE-9B31-A19503B9AAD1-77302942!pb-smtp21.pobox.com List-Unsubscribe-Post: List-Unsubscribe=One-Click Dorcas Litunya writes: > Bcc: > Subject: Re: [PATCH] t/t7601: Modernize test scripts using functions > Reply-To: > In-Reply-To: What are these lines doing here? > So should I replace this in the next version or leave this as is? Perhaps I was not clear enough, but I found the commit title and description need to be updated to clearly record the intent of the change with a handful of points, so I will not be accepting the patch as-is. These two sections may be of help. Documentation/MyFirstContribution.txt::now-what Documentation/MyFirstContribution.txt::reviewing Thanks.