git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Maarten de Vries <maarten@de-vri.es>,
	git mailing list <git@vger.kernel.org>,
	Martin von Zweigbergk <martinvonz@gmail.com>
Subject: Re: Re* Bug report: reset -p HEAD
Date: Fri, 25 Oct 2013 09:54:52 -0700	[thread overview]
Message-ID: <xmqqiowljnoj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131025042421.GB11810@sigill.intra.peff.net> (Jeff King's message of "Fri, 25 Oct 2013 00:24:21 -0400")

Jeff King <peff@peff.net> writes:

>   3. Teach add--interactive to recognize the empty tree sha1 as an
>      "unstage" path.
>
> I kind of like (3). At first glance, it is wrong; we will also treat
> "git reset -p $(git hash-object -t tree /dev/null)" as if "HEAD" had
> been passed. But if you are explicitly passing the empty tree like that,
> I think saying "unstage" makes a lot of sense.

Thanks; makes sense after twisting my mind somewhat, exactly for the
reason you stated here ;-)

      parent reply	other threads:[~2013-10-25 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPWpf+wi0zH2sOnuqiZuKkf+kC0RMug_ASb-J-TGGLd2RFT1wg@mail.gmail.com>
     [not found] ` <CAPWpf+xqutvhq1jyVkxr6LyKsANTCS6M=vj5XY=EgUfiS3Z8xg@mail.gmail.com>
2013-10-24 23:05   ` Fwd: Bug report: reset -p HEAD Maarten de Vries
2013-10-24 23:16     ` Maarten de Vries
2013-10-25  3:40       ` Re* " Junio C Hamano
2013-10-25  4:24         ` Jeff King
2013-10-25  5:42           ` Martin von Zweigbergk
2013-10-25  6:51             ` [PATCH 0/2] reset -p and unborn branches Jeff King
2013-10-25  6:52               ` [PATCH 1/2] add-interactive: handle unborn branch in patch mode Jeff King
2013-10-25  6:54               ` [PATCH 2/2] reset: pass real rev name to add--interactive Jeff King
2013-10-25 16:54           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiowljnoj.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=maarten@de-vri.es \
    --cc=martinvonz@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).