git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH v2] init-db: remove unused include
@ 2015-01-15 11:47 Alexander Kuleshov
  2015-01-15 19:11 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2015-01-15 11:47 UTC (permalink / raw
  To: Junio C Hamano; +Cc: git, Alexander Kuleshov

"cache.h" removed, because it's already included at "builtin.h"

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 builtin/init-db.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/builtin/init-db.c b/builtin/init-db.c
index 280454a..8edef87 100644
--- a/builtin/init-db.c
+++ b/builtin/init-db.c
@@ -3,7 +3,6 @@
  *
  * Copyright (C) Linus Torvalds, 2005
  */
-#include "cache.h"
 #include "builtin.h"
 #include "exec_cmd.h"
 #include "parse-options.h"
-- 
2.3.0.rc0.256.g2ad8601.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] init-db: remove unused include
  2015-01-15 11:47 [PATCH v2] init-db: remove unused include Alexander Kuleshov
@ 2015-01-15 19:11 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2015-01-15 19:11 UTC (permalink / raw
  To: Alexander Kuleshov; +Cc: git

Alexander Kuleshov <kuleshovmail@gmail.com> writes:

> "cache.h" removed, because it's already included at "builtin.h"
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---

Let's put this on hold.

$ git grep --all-match -l -e cache\\.h -e builtin\\.h -- \*.c

shows us there are tons, not just this one.

Also I'd like to see this discussion simmer a bit more:

  http://thread.gmane.org/gmane.comp.version-control.git/262454/focus=262499

>  builtin/init-db.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index 280454a..8edef87 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -3,7 +3,6 @@
>   *
>   * Copyright (C) Linus Torvalds, 2005
>   */
> -#include "cache.h"
>  #include "builtin.h"
>  #include "exec_cmd.h"
>  #include "parse-options.h"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-15 19:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 11:47 [PATCH v2] init-db: remove unused include Alexander Kuleshov
2015-01-15 19:11 ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).