From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>
Subject: Re: [PATCH] notes: Allow treeish expressions as notes ref
Date: Mon, 13 Jul 2015 14:15:54 -0700 [thread overview]
Message-ID: <xmqqio9nzrlh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150713205304.GA26911@glandium.org> (Mike Hommey's message of "Tue, 14 Jul 2015 05:53:04 +0900")
Mike Hommey <mh@glandium.org> writes:
>> - Make sure that we show "there is no such tree-ish, no way to look
>> up any note to any commit from there" and "I understood the tree
>> you gave me, but there is no note for that commit" differently.
>
> How would you reconcile that with the usual "there are only a couple
> commits with a note in the hundreds you make me display"?
I am talking about the difference between "a tree exists (which may
lack notes for a given commit)" and "a tree does not even exist in
the first place". This patch removed "a tree exists but that is not
a ref so we silently ignore", but I do not know if that change alone
covers everything---do you?
>> - Decide if we want to "fail" the operation when the notes tree
>> given by the user is not even a tree-ish or just "warn" and keep
>> going. And do so consistently.
>
> Is this something you want to be figured before merging this patch?
Depends on the definition of 'merging'. I queued this one on 'pu',
and have no intention to merge it down to 'master' by the end of
this month; in the meantime either incremental or replacement
refinement can certainly address that inconsistency I'd hope ;-)
Thanks.
next prev parent reply other threads:[~2015-07-13 21:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 1:15 [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Mike Hommey
2015-06-17 3:17 ` Junio C Hamano
2015-06-17 9:40 ` Mike Hommey
2015-06-17 15:18 ` Junio C Hamano
2015-06-17 16:35 ` Johan Herland
2015-07-08 10:21 ` [PATCH v2 - RFH] notes: Allow committish expressions as notes ref Mike Hommey
2015-07-09 2:48 ` [PATCH v3] " Mike Hommey
2015-07-10 1:03 ` Johan Herland
2015-07-10 1:28 ` [PATCH v4] notes: Allow treeish " Mike Hommey
2015-07-10 7:16 ` Johan Herland
2015-07-10 7:22 ` Mike Hommey
2015-07-10 8:39 ` [PATCH] " Mike Hommey
2015-07-13 16:35 ` Junio C Hamano
2015-07-13 20:53 ` Mike Hommey
2015-07-13 21:15 ` Junio C Hamano [this message]
2015-10-08 2:50 ` Mike Hommey
2015-10-08 2:54 ` [PATCH v6] notes: allow " Mike Hommey
2015-10-08 19:03 ` [PATCH] notes: Allow " Junio C Hamano
2015-07-13 21:19 ` Junio C Hamano
2015-06-17 3:22 ` [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Jeff King
2015-06-17 9:02 ` Mike Hommey
2015-06-17 16:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqio9nzrlh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).