From: Junio C Hamano <gitster@pobox.com>
To: Daniel Ferreira <bnmvco@gmail.com>
Cc: git@vger.kernel.org, sbeller@google.com, pclouds@gmail.com,
mhagger@alum.mit.edu
Subject: Re: [PATCH v9 4/5] dir_iterator: refactor state machine model
Date: Mon, 17 Apr 2017 22:13:09 -0700 [thread overview]
Message-ID: <xmqqinm2e1sq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1492462296-4990-5-git-send-email-bnmvco@gmail.com> (Daniel Ferreira's message of "Mon, 17 Apr 2017 17:51:35 -0300")
Daniel Ferreira <bnmvco@gmail.com> writes:
> ...
> Signed-off-by: Daniel Ferreira <bnmvco@gmail.com>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
I had an impression that you took Michael's code snippet and wrote
this patch, and if that is the case, the flow of the patch is from
Michael to you to me, so these lines are out of order.
Describing which part of this patch owes Michael's contribution in
the log message would also not hurt.
next prev parent reply other threads:[~2017-04-18 5:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 20:51 [PATCH v9 0/5] [GSoC] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-17 20:51 ` [PATCH v9 1/5] dir_iterator: add tests for dir_iterator API Daniel Ferreira
2017-04-18 4:12 ` Junio C Hamano
2017-04-18 4:37 ` Junio C Hamano
2017-04-17 20:51 ` [PATCH v9 2/5] remove_subtree(): test removing nested directories Daniel Ferreira
2017-04-17 20:51 ` [PATCH v9 3/5] dir_iterator: add helpers to dir_iterator_advance Daniel Ferreira
2017-04-18 4:23 ` Junio C Hamano
2017-04-17 20:51 ` [PATCH v9 4/5] dir_iterator: refactor state machine model Daniel Ferreira
2017-04-18 4:35 ` Junio C Hamano
2017-04-18 5:13 ` Junio C Hamano [this message]
2017-04-17 20:51 ` [PATCH v9 5/5] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-18 4:09 ` [PATCH v9 0/5] [GSoC] " Junio C Hamano
2017-04-18 18:45 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqinm2e1sq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).