From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: git@vger.kernel.org, me@ikke.info
Subject: Re: [PATCH] commit & merge: modularize the empty message validator
Date: Thu, 13 Jul 2017 12:23:45 -0700 [thread overview]
Message-ID: <xmqqiniww37i.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1499969722.5973.2.camel@gmail.com> (Kaartic Sivaraam's message of "Thu, 13 Jul 2017 23:45:22 +0530")
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> I have a few doubts for which I need clarification to move on with
> this.
>
> 1. If we abort when the <message> part is empty wouldn't it be too
> restrictive ?
>
> IOW, Wouldn't it affect users of "git commit --cleanup=verbatim"
> who wish to commit only the comments or parts of it ?
> (I'm not sure if someone would find that useful)
>
> 2. Is it ok to use the "find_trailer_start" function of "trailer.c"
> to locate the trailer?
>
> Note: It has a little issue that it wouldn't detect the trailer if
> the message comprises of one trailer alone and no other text. This
> case occurs while aborting a commit started using "git commit -s".
> Any possibilities to overcome the issue?
>
> 3. Ignoring point 1 for now, What other helper methods except the
> ones listed below could be helpful in the separating the cleaned up
> commit message into the <message>, <trailer>, <junk-at-tail> ?
>
> * ignore_non_trailer
> * find_trailer_start
All good points; if it bothers you that "commit" and "merge" define
"emptyness" of the buffer differently too much, I think you could
persuade me to unify them to "the buffer _must_ contain no bytes",
i.e. not special-casing sign-off lines only "commit".
It would be a backward incompatible tightening of the established
rule, but it may not be a bad change.
next prev parent reply other threads:[~2017-07-13 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 12:03 Why doesn't merge fail if message has only sign-off? Kaartic Sivaraam
2017-07-03 17:21 ` Junio C Hamano
2017-07-04 20:03 ` Kaartic Sivaraam
2017-07-06 3:31 ` [PATCH] merge-message: change meaning of "empty merge message" Kaartic Sivaraam
2017-07-06 4:46 ` Kevin Daudt
2017-07-06 12:20 ` Kaartic Sivaraam
2017-07-11 14:12 ` [PATCH] commit & merge: modularize the empty message validator Kaartic Sivaraam
2017-07-11 14:41 ` [PATCH/RFC] " Kaartic Sivaraam
2017-07-11 20:22 ` [PATCH] " Junio C Hamano
2017-07-13 13:00 ` Kaartic Sivaraam
2017-07-13 17:58 ` Junio C Hamano
2017-07-14 13:31 ` Kaartic Sivaraam
2017-07-17 9:08 ` Christian Brabandt
2017-07-17 17:16 ` Junio C Hamano
2017-07-13 18:15 ` Kaartic Sivaraam
2017-07-13 19:23 ` Junio C Hamano [this message]
2017-07-14 17:49 ` Kaartic Sivaraam
2017-07-15 8:33 ` Kaartic Sivaraam
2017-08-21 13:34 ` [PATCH v2] branch: change the error messages to be more meaningful Kaartic Sivaraam
2017-08-21 13:52 ` Kaartic Sivaraam
2017-08-21 14:05 ` [PATCH v2/RFC] commit: change the meaning of an empty commit message Kaartic Sivaraam
2017-08-24 20:19 ` Junio C Hamano
2017-08-31 13:36 ` Kaartic Sivaraam
2017-10-02 17:20 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiniww37i.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaarticsivaraam91196@gmail.com \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).