From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] recursive submodules: detach HEAD from new state
Date: Mon, 24 Jul 2017 13:57:11 -0700 [thread overview]
Message-ID: <xmqqinihd048.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kaYzHzSdDZuMpM6UFXLon0SME-nC=9_09PLhLEADfuscw@mail.gmail.com> (Stefan Beller's message of "Mon, 24 Jul 2017 12:07:48 -0700")
Stefan Beller <sbeller@google.com> writes:
>> Are you saying
>> the current behavior of updating whatever branch HEAD is on (which,
>> don't get me wrong, is a wrong behavior that needs fixing) bypassed
>> the reflog?
>
> No, I am not saying that.
> I am saying that updating an unrelated branch (which is dragged into
> the affair just because HEAD points at it) is very subtle thing, as any
> commits on that branch can be considered safe (it is on a branch, right?)
> but the detached HEAD is the default unsafe mode we currently have.
Then it is not a data loss as you claimed in the proposed log
message, but is something else, no?
next prev parent reply other threads:[~2017-07-24 20:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:36 [PATCH] recursive submodules: detach HEAD from new state Stefan Beller
2017-07-24 18:03 ` Jonathan Nieder
2017-07-24 19:07 ` Stefan Beller
2017-07-24 20:57 ` Junio C Hamano [this message]
2017-07-24 21:33 ` Junio C Hamano
2017-07-24 22:23 ` Junio C Hamano
2017-07-25 22:27 ` Stefan Beller
2017-07-26 19:36 ` Junio C Hamano
2017-11-21 22:34 ` Jonathan Nieder
2017-11-21 22:45 ` Stefan Beller
2017-11-21 22:47 ` Jonathan Nieder
2017-11-21 23:00 ` Stefan Beller
2017-11-22 0:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqinihd048.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).