From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: <git@vger.kernel.org>
Subject: Re: [Proposed] Externalize man/html ref for quick-install-man and quick-install-html
Date: Mon, 11 Dec 2017 15:27:14 -0800 [thread overview]
Message-ID: <xmqqindc4zhp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <000801d3713a$2f1259d0$8d370d70$@nexbridge.com> (Randall S. Becker's message of "Sat, 9 Dec 2017 17:07:57 -0500")
"Randall S. Becker" <rsbecker@nexbridge.com> writes:
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 3e39e28..4f1e6df 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -39,6 +39,8 @@ MAN_TXT = $(MAN1_TXT) $(MAN5_TXT) $(MAN7_TXT)
> MAN_XML = $(patsubst %.txt,%.xml,$(MAN_TXT))
> MAN_HTML = $(patsubst %.txt,%.html,$(MAN_TXT))
>
> +GIT_MAN_REF = master
> +
> OBSOLETE_HTML += everyday.html
> OBSOLETE_HTML += git-remote-helpers.html
> DOC_HTML = $(MAN_HTML) $(OBSOLETE_HTML)
> @@ -415,14 +417,14 @@ require-manrepo::
> then echo "git-manpages repository must exist at $(MAN_REPO)"; exit
> 1; fi
>
> quick-install-man: require-manrepo
> - '$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO)
> $(DESTDIR)$(mandir)
> + '$(SHELL_PATH_SQ)' ./install-doc-quick.sh $(MAN_REPO)
> $(DESTDIR)$(mandir) $(GIT_MAN_REF)
I suspect that this patch is line-wrapped and unusable for the final
application, but I think what the change wants to do makes total
sense---we are already letting the builder specify where the other
repositories for docs are, and it is not such a big stretch to let
them also say which branch or tag they want their documentation
from.
next prev parent reply other threads:[~2017-12-11 23:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 22:07 [Proposed] Externalize man/html ref for quick-install-man and quick-install-html Randall S. Becker
2017-12-11 23:27 ` Junio C Hamano [this message]
2017-12-12 0:26 ` Randall S. Becker
2017-12-12 10:50 ` Jacob Keller
2017-12-12 23:17 ` Junio C Hamano
2017-12-12 23:23 ` Randall S. Becker
2017-12-12 23:40 ` Junio C Hamano
2017-12-12 23:54 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqindc4zhp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).