git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
@ 2018-01-14 18:07 randall.s.becker
  2018-01-15 20:43 ` Thomas Gummerer
  0 siblings, 1 reply; 5+ messages in thread
From: randall.s.becker @ 2018-01-14 18:07 UTC (permalink / raw)
  To: git; +Cc: Randall S. Becker

From: "Randall S. Becker" <rsbecker@nexbridge.com>

* hashmap.h: Revised the while loop in the hashmap_enable_item_counting
	to remove unneeded void* item.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 hashmap.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hashmap.h b/hashmap.h
index 7ce79f3..d375d9c 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
  */
 static inline void hashmap_enable_item_counting(struct hashmap *map)
 {
-	void *item;
 	unsigned int n = 0;
 	struct hashmap_iter iter;
 
@@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
 		return;
 
 	hashmap_iter_init(map, &iter);
-	while ((item = hashmap_iter_next(&iter)))
+	while (hashmap_iter_next(&iter))
 		n++;
 
 	map->do_count_items = 1;
-- 
2.8.5.23.g6fa7ec3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
  2018-01-14 18:07 [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
@ 2018-01-15 20:43 ` Thomas Gummerer
  2018-01-15 20:49   ` Randall S. Becker
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gummerer @ 2018-01-15 20:43 UTC (permalink / raw)
  To: randall.s.becker; +Cc: git, Randall S. Becker

Thanks for your patch!  A few nitpicks below:

> Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings

From Documentation/SubmittingPatches:

    Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
    instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
    to do frotz", as if you are giving orders to the codebase to change
    its behavior.

I liked the subject Philip suggested in the other thread: "hashmap.h:
remove unnecessary void*", or maybe "hashmap.h: remove unnecessary
variable".

On 01/14, randall.s.becker@rogers.com wrote:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
> 
> * hashmap.h: Revised the while loop in the hashmap_enable_item_counting
> 	to remove unneeded void* item.

As above, this should be described in an imperative mood, and describe
why this is a good change and should be merged.  Maybe something along
the lines of the below?

    In 'hashmap_enable_item_counting()', item is assigned but never
    used.  This causes a warning on HP NonStop.  As the variable is
    never used, fix this by just removing it.

> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
>  hashmap.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hashmap.h b/hashmap.h
> index 7ce79f3..d375d9c 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
>   */
>  static inline void hashmap_enable_item_counting(struct hashmap *map)
>  {
> -	void *item;
>  	unsigned int n = 0;
>  	struct hashmap_iter iter;
>  
> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
>  		return;
>  
>  	hashmap_iter_init(map, &iter);
> -	while ((item = hashmap_iter_next(&iter)))
> +	while (hashmap_iter_next(&iter))
>  		n++;
>  
>  	map->do_count_items = 1;
> -- 
> 2.8.5.23.g6fa7ec3
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
  2018-01-15 20:43 ` Thomas Gummerer
@ 2018-01-15 20:49   ` Randall S. Becker
  2018-01-15 23:59     ` Thomas Gummerer
  2018-01-16 22:28     ` Junio C Hamano
  0 siblings, 2 replies; 5+ messages in thread
From: Randall S. Becker @ 2018-01-15 20:49 UTC (permalink / raw)
  To: 'Thomas Gummerer'; +Cc: git

On January 15, 2018 3:43 PM, Thomas Gummerer wrote:
> Thanks for your patch!  A few nitpicks below:
> 
> > Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused
> > compile warnings
> 
> From Documentation/SubmittingPatches:
> 
>     Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
>     instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
>     to do frotz", as if you are giving orders to the codebase to change
>     its behavior.
> 
> I liked the subject Philip suggested in the other thread: "hashmap.h:
> remove unnecessary void*", or maybe "hashmap.h: remove unnecessary
> variable".
> 
> On 01/14, randall.s.becker@rogers.com wrote:
> > From: "Randall S. Becker" <rsbecker@nexbridge.com>
> >
> > * hashmap.h: Revised the while loop in the
> hashmap_enable_item_counting
> > 	to remove unneeded void* item.
> 
> As above, this should be described in an imperative mood, and describe why
> this is a good change and should be merged.  Maybe something along the
> lines of the below?
> 
>     In 'hashmap_enable_item_counting()', item is assigned but never
>     used.  This causes a warning on HP NonStop.  As the variable is
>     never used, fix this by just removing it.
> 
> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> > ---
> >  hashmap.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/hashmap.h b/hashmap.h
> > index 7ce79f3..d375d9c 100644
> > --- a/hashmap.h
> > +++ b/hashmap.h
> > @@ -400,7 +400,6 @@ static inline void
> hashmap_disable_item_counting(struct hashmap *map)
> >   */
> >  static inline void hashmap_enable_item_counting(struct hashmap *map)
> > {
> > -	void *item;
> >  	unsigned int n = 0;
> >  	struct hashmap_iter iter;
> >
> > @@ -408,7 +407,7 @@ static inline void
> hashmap_enable_item_counting(struct hashmap *map)
> >  		return;
> >
> >  	hashmap_iter_init(map, &iter);
> > -	while ((item = hashmap_iter_next(&iter)))
> > +	while (hashmap_iter_next(&iter))
> >  		n++;
> >
> >  	map->do_count_items = 1;

I like it. Do you need this resubmitted? Or should I just learn for next
time?

Cheers,
Randall


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
  2018-01-15 20:49   ` Randall S. Becker
@ 2018-01-15 23:59     ` Thomas Gummerer
  2018-01-16 22:28     ` Junio C Hamano
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Gummerer @ 2018-01-15 23:59 UTC (permalink / raw)
  To: Randall S. Becker; +Cc: git

On 01/15, Randall S. Becker wrote:
> On January 15, 2018 3:43 PM, Thomas Gummerer wrote:
> > Thanks for your patch!  A few nitpicks below:
> > 
> > > Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused
> > > compile warnings
> > 
> > From Documentation/SubmittingPatches:
> > 
> >     Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> >     instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> >     to do frotz", as if you are giving orders to the codebase to change
> >     its behavior.
> > 
> > I liked the subject Philip suggested in the other thread: "hashmap.h:
> > remove unnecessary void*", or maybe "hashmap.h: remove unnecessary
> > variable".
> > 
> > On 01/14, randall.s.becker@rogers.com wrote:
> > > From: "Randall S. Becker" <rsbecker@nexbridge.com>
> > >
> > > * hashmap.h: Revised the while loop in the
> > hashmap_enable_item_counting
> > > 	to remove unneeded void* item.
> > 
> > As above, this should be described in an imperative mood, and describe why
> > this is a good change and should be merged.  Maybe something along the
> > lines of the below?
> > 
> >     In 'hashmap_enable_item_counting()', item is assigned but never
> >     used.  This causes a warning on HP NonStop.  As the variable is
> >     never used, fix this by just removing it.
> > 
> > > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> > >
> > > [..snip..]
> > >
> I like it. Do you need this resubmitted? Or should I just learn for next
> time?

I think it would be good if you resubmit the patch.  These rules tend
to be applied quite strictly, as you can also see when looking at the
git commit history.  So with the updated commit message Junio should
just be able to pick it up (unless there's something I missed here as
well :))

As a side note, I just noticed the two submissions both had [PATCH] in
the title, whereas new submissions should be marked as such using
[PATCH v2] etc. as prefix, so it's easier for reviewers to know which
version is the newer one.

> Cheers,
> Randall
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings
  2018-01-15 20:49   ` Randall S. Becker
  2018-01-15 23:59     ` Thomas Gummerer
@ 2018-01-16 22:28     ` Junio C Hamano
  1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2018-01-16 22:28 UTC (permalink / raw)
  To: Randall S. Becker; +Cc: Thomas Gummerer, git

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

> I like it. Do you need this resubmitted? Or should I just learn for next
> time?

I'll queue the attached for today's iteration.  Thanks, both.

-- >8 --
From: "Randall S. Becker" <rsbecker@nexbridge.com>
Date: Sun, 14 Jan 2018 13:07:48 -0500
Subject: [PATCH] hashmap.h: remove unused variable

In 'hashmap_enable_item_counting()', item is assigned but never
used.  This causes a warning on HP NonStop.  As the variable is
never used, fix this by just removing it.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
Helped-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 hashmap.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hashmap.h b/hashmap.h
index 7cb29a6aed..c41ce392b7 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -402,7 +402,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
  */
 static inline void hashmap_enable_item_counting(struct hashmap *map)
 {
-	void *item;
 	unsigned int n = 0;
 	struct hashmap_iter iter;
 
@@ -410,7 +409,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
 		return;
 
 	hashmap_iter_init(map, &iter);
-	while ((item = hashmap_iter_next(&iter)))
+	while (hashmap_iter_next(&iter))
 		n++;
 
 	map->do_count_items = 1;
-- 
2.16.0-rc2-196-ge713b39cb6


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-01-16 22:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-14 18:07 [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
2018-01-15 20:43 ` Thomas Gummerer
2018-01-15 20:49   ` Randall S. Becker
2018-01-15 23:59     ` Thomas Gummerer
2018-01-16 22:28     ` Junio C Hamano

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git