From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
ungureanupaulsebastian@gmail.com,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static
Date: Fri, 02 Mar 2018 09:19:53 -0800 [thread overview]
Message-ID: <xmqqinaecs3q.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <733494ed-56b1-9072-3c9d-cedc35acd215@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 2 Mar 2018 17:06:27 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Junio, do you want me to re-roll, or would you mind tweaking the
> commit message while queueing?
Perfect timing ;-) I was about to get to these two patches. Here
is what is queued.
commit 2d7cb07e3718d0af6547e2abb35f9cff9b10c1f5
Author: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Fri Mar 2 02:54:02 2018 +0000
ref-filter: mark a file-local symbol as static
Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if
<id> is invalid', 2018-02-23) added the add_str_to_commit_list()
function, which causes sparse to issue a "... not declared. Should it
be static?" warning for that symbol.
Indeed, the function is only used in this one compilation unit. Mark
it static.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/ref-filter.c b/ref-filter.c
index aa282a27f4..ed993d32d8 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -2000,7 +2000,7 @@ static void do_merge_filter(struct ref_filter_cbdata *ref_cbdata)
free(to_clear);
}
-int add_str_to_commit_list(struct string_list_item *item, void *commit_list)
+static int add_str_to_commit_list(struct string_list_item *item, void *commit_list)
{
struct object_id oid;
struct commit *commit;
next prev parent reply other threads:[~2018-03-02 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 2:54 [PATCH 1/2] ref-filter: mark a file-local symbol as static Ramsay Jones
2018-03-02 3:59 ` Jonathan Nieder
2018-03-02 17:06 ` Ramsay Jones
2018-03-02 17:19 ` Junio C Hamano [this message]
2018-03-02 17:56 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqinaecs3q.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).