From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 516C91F463 for ; Sat, 30 Nov 2019 17:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726981AbfK3RZP (ORCPT ); Sat, 30 Nov 2019 12:25:15 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:51850 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbfK3RZP (ORCPT ); Sat, 30 Nov 2019 12:25:15 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id C497636076; Sat, 30 Nov 2019 12:25:12 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=lNYtvNe+i9OUiecc58eyNkP4CJU=; b=u6eMLB woYV0a2sZUZVv+AMVCmcnZOH7tm/kAzsNRatHvKn/qv6rjcyUTlK8XSL30ExtO0x 8D5zlGKkY65xFnRhYQvZmHCwrcAzGwZ7yYTMRkbMWkHyKttJMflcZelSvGPJdZDZ PkCfR1ZDLM4PtDTM+05hRw3J8DzA+iBwoTs40= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=fsruU6WV0AsQDP4pOjaz0bv17S5hTgtn uQ9qOPc3fqgHd5lBMS3gxdV5FdDKpHElYQn07tc9mh+j+/PgukQggK8PDqbI9GXp zWBoZSvSHsGsWSTni2/huTYuEofoy0motVbAA/GmQ3LifjG1/rugEYOTrsyTv5O5 B5XWk7kce78= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id BB9B336074; Sat, 30 Nov 2019 12:25:12 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 0B9CC36072; Sat, 30 Nov 2019 12:25:11 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Eric Sunshine Cc: Denton Liu , Git Mailing List , Christian Biesinger Subject: Re: [PATCH 1/5] t3400: demonstrate failure with format.useAutoBase References: Date: Sat, 30 Nov 2019 09:25:10 -0800 In-Reply-To: (Eric Sunshine's message of "Tue, 26 Nov 2019 21:26:58 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5D5D8DEA-1396-11EA-B905-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Eric Sunshine writes: > On Tue, Nov 26, 2019 at 9:09 PM Denton Liu wrote: >> Ever since bb52995f3e (format-patch: introduce format.useAutoBase >> configuration, 2016-04-26), `git rebase` has been broken when >> `format.useAutoBase = true`. Demonstrate that failure here. > > What specifically does "broken" mean here? > >> Reported-by: Christian Biesinger >> Signed-off-by: Denton Liu >> --- >> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh >> @@ -159,6 +159,12 @@ test_expect_success 'fail when upstream arg is missing and not configured' ' >> +test_expect_failure 'rebase works with format.useAutoBase' ' >> + test_config format.useAutoBase true && >> + git checkout topic && >> + git rebase master >> +' > > Having read both the commit message and the test itself, I'm not wiser > about what is actually "broken" or what this is demonstrating. True. The tests must be crystal clear what kind of brokenness it is demonstrating, not just "this test is expected to fail", especially when the "expect failure in one step, fix and flip expectation in a separate step" pattern is used; otherwise it becomes doubly puzzling. Thanks.