From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EA8B01F463 for ; Wed, 18 Dec 2019 22:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfLRWGr (ORCPT ); Wed, 18 Dec 2019 17:06:47 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61973 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726512AbfLRWGq (ORCPT ); Wed, 18 Dec 2019 17:06:46 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A5DED1E10C; Wed, 18 Dec 2019 17:06:44 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=/GWnb4JYaL6nvZOzjgz0BDDl2Wg=; b=AXznCt faBT2PRDgRT1+rtilUV+1rDMLKChqU7iIMOEmQrAN0gUhFFyRslMLZgxt4hdcMtT Ky9kq3x+qPUpcpqbzrUbAqYd9YOCs1UVJNCcOPIhaEVZmLxlZkofzyT0VnAmCGtT GwEhfYICwmPaVHvj4kEbWUxWE+6jKoRrNtAjk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=smlPj5xk+U6fxd3tTH6XLC6ITM03RODA Mxb0A097/uvyuZO6G2hSGf4A/CPdI6uEFFkIJDj+fESeqh+hPgRaP3pfIgYyhT0L /oqJfWtlBg7UyAC5XvxniPQcIvjSThc+ABg/QIvgLTlqMlb35nQP8E/xnEjDbIMJ G66O8Z9OHeo= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9D0BB1E10B; Wed, 18 Dec 2019 17:06:44 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 141A51E10A; Wed, 18 Dec 2019 17:06:44 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: Alexandr Miloslavskiy via GitGitGadget , git@vger.kernel.org, Emily Shaffer , Derrick Stolee , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Alexandr Miloslavskiy Subject: Re: [PATCH v2 04/18] commit: forbid --pathspec-from-file --all References: <195a5b2a-994a-5984-8cc7-280a698df2a0@gmail.com> Date: Wed, 18 Dec 2019 14:06:43 -0800 In-Reply-To: (Junio C. Hamano's message of "Wed, 18 Dec 2019 14:04:26 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: AD3CE9E6-21E2-11EA-84EE-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Phillip Wood writes: > >> Hi Alexandr >> >> This looks good, thanks for the test >> >> Best Wishes >> >> Phillip >> >> On 16/12/2019 15:47, Alexandr Miloslavskiy via GitGitGadget wrote: >>> From: Alexandr Miloslavskiy >>> >>> I forgot this in my previous patch `--pathspec-from-file` for >>> `git commit` [1]. When both `--pathspec-from-file` and `--all` were >>> ... >>> [1] Commit e440fc58 ("commit: support the --pathspec-from-file option" 2019-11-19) > > Thanks, both. I will take this separately and queue directly on top > of am/pathspec-from-file to fast-track it, rather than leaving it as > a part of larger topic that would take more time to mature. Sigh... the test part of this patch is taken hostage to an earlier patches in this series that are iffy, so I cannot quite apply this fix alone at this moment. Yuck.