From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] check-ignore: fix handling with negated patterns
Date: Mon, 17 Feb 2020 10:04:58 -0800 [thread overview]
Message-ID: <xmqqimk5ks39.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <pull.711.git.git.1581956106255.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Mon, 17 Feb 2020 16:15:06 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Elijah Newren <newren@gmail.com>
>
> check-ignore was meant to check ignore rules the same way git status and
> other commands would, and to report whether a path is excluded. It
> failed to do this (and generated a few bug reports), however, because it
> did not account for negated patterns.
I suspect that the above distorts history. IIRC, it was meant as a
tool to see which exact pattern in the exclude sequence had the
final say for the given needle, written primarily as a debugging
aid. In that context, "This rule has the final say", whether the
rule is a negative or positive, still means something.
It is just the behavior is _much_ less useful for those who want to
know what the final say is, and I tend to agree that we probably are
better off changing its output to reflect "so, are we ignoring the
path after all? yes/no?" because we are pretty much done with
debugging the exclude API implementation.
next prev parent reply other threads:[~2020-02-17 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:15 [PATCH] check-ignore: fix handling with negated patterns Elijah Newren via GitGitGadget
2020-02-17 18:04 ` Junio C Hamano [this message]
2020-02-17 18:41 ` Elijah Newren
2020-02-17 20:41 ` Junio C Hamano
2020-02-17 21:07 ` Elijah Newren
2020-02-19 21:36 ` Junio C Hamano
2020-02-18 20:36 ` [PATCH v2] check-ignore: fix documentation and implementation to match Elijah Newren via GitGitGadget
2020-02-18 21:27 ` Junio C Hamano
2020-02-18 23:05 ` [PATCH v3] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimk5ks39.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).