git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] command-list.txt: add gitfaq to the list of guides
@ 2020-05-20 14:44 Philippe Blain via GitGitGadget
  2020-05-20 15:54 ` Junio C Hamano
  2020-05-21  1:53 ` brian m. carlson
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Blain via GitGitGadget @ 2020-05-20 14:44 UTC (permalink / raw)
  To: git; +Cc: brian m. carlson, Philippe Blain, Philippe Blain

From: Philippe Blain <levraiphilippeblain@gmail.com>

When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
it was added to the Makefile but not to command-list.txt.

Add it there also, so that the new FAQ is listed in the output of
`git help --guides`.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
    command-list.txt: add gitfaq to the list of guides
    
    The new FAQ is not listed in command-list.txt, so it does not show up in 
    git help --guides.
    
    I think this should be included in 2.27.0.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-639%2Fphil-blain%2Flist-faq-in-guides-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-639/phil-blain/list-faq-in-guides-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/639

 command-list.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/command-list.txt b/command-list.txt
index 185e5e3f05f..cbb960c8436 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -198,6 +198,7 @@ gitcore-tutorial                        guide
 gitcvs-migration                        guide
 gitdiffcore                             guide
 giteveryday                             guide
+gitfaq                                  guide
 gitglossary                             guide
 githooks                                guide
 gitignore                               guide

base-commit: efcab5b7a3d2ce2ae4bf808b335938098b18d960
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] command-list.txt: add gitfaq to the list of guides
  2020-05-20 14:44 [PATCH] command-list.txt: add gitfaq to the list of guides Philippe Blain via GitGitGadget
@ 2020-05-20 15:54 ` Junio C Hamano
  2020-05-21  1:53 ` brian m. carlson
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2020-05-20 15:54 UTC (permalink / raw)
  To: Philippe Blain via GitGitGadget; +Cc: git, brian m. carlson, Philippe Blain

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
>
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for sharp eyes.

Will queue, but it may be post -rc1.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] command-list.txt: add gitfaq to the list of guides
  2020-05-20 14:44 [PATCH] command-list.txt: add gitfaq to the list of guides Philippe Blain via GitGitGadget
  2020-05-20 15:54 ` Junio C Hamano
@ 2020-05-21  1:53 ` brian m. carlson
  1 sibling, 0 replies; 3+ messages in thread
From: brian m. carlson @ 2020-05-21  1:53 UTC (permalink / raw)
  To: Philippe Blain via GitGitGadget; +Cc: git, Philippe Blain

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On 2020-05-20 at 14:44:48, Philippe Blain via GitGitGadget wrote:
> From: Philippe Blain <levraiphilippeblain@gmail.com>
> 
> When 'gitfaq.txt' was added in 2149b6748f (docs: add a FAQ, 2020-03-30),
> it was added to the Makefile but not to command-list.txt.
> 
> Add it there also, so that the new FAQ is listed in the output of
> `git help --guides`.

Thanks for catching this.  This seems obviously correct.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-21  1:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 14:44 [PATCH] command-list.txt: add gitfaq to the list of guides Philippe Blain via GitGitGadget
2020-05-20 15:54 ` Junio C Hamano
2020-05-21  1:53 ` brian m. carlson

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).