From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v2 2/9] completion: improve handling of DWIM mode for switch/checkout
Date: Wed, 27 May 2020 11:03:50 -0700 [thread overview]
Message-ID: <xmqqimghl0ft.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200527113831.3294409-3-jacob.e.keller@intel.com> (Jacob Keller's message of "Wed, 27 May 2020 04:38:24 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
> This new logic is more robust, as we will correctly identify superseded
> options, and ensure that both _git_switch and _git_checkout enable DWIM
> in similar ways.
>
> Add several tests which demonstrate the new expected behavior. Note that
> some of the git switch tests are marked as failures because the default
> git switch completion with --guess is sub-par as discussed in a previous
> commit. This will be fixed in a future change.
"as discussed in a previous commit"? 1/9 does not mention --guess
at all. Perhaps this is an unintended damage due to rebasing?
In any case, up to this point, the log messages are a bit
frustrating read, primarily because the author has spent too much
time on DWIM and expect everybody understands exactly what he means
when he says "DWIM mode is enabled", while a reader in me keeps
asking:
- what refs get included when I type <TAB> without DWIM mode?
- what extra refs get included when DWIM mode is enabled?
- under DWIM mode, do certain refs (that would be included without
DWIM mode) stop appearing in the completion?
and without getting any answer to them. Perhaps the proposed log
message for [1/9] can be made a bit more robust to cover it?
Thanks.
next prev parent reply other threads:[~2020-05-27 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:38 [PATCH v2 0/9] refactor completion for switch and checkout Jacob Keller
2020-05-27 11:38 ` [PATCH v2 1/9] completion: replace overloaded track term for __git_complete_refs Jacob Keller
2020-05-27 11:38 ` [PATCH v2 2/9] completion: improve handling of DWIM mode for switch/checkout Jacob Keller
2020-05-27 18:03 ` Junio C Hamano [this message]
2020-05-27 19:41 ` Jacob Keller
2020-05-28 8:53 ` Jacob Keller
2020-05-27 11:38 ` [PATCH v2 3/9] completion: extract function __git_dwim_remote_heads Jacob Keller
2020-05-27 11:38 ` [PATCH v2 4/9] completion: perform DWIM logic directly in __git_complete_refs Jacob Keller
2020-05-27 11:38 ` [PATCH v2 5/9] completion: improve completion for git switch with no options Jacob Keller
2020-05-27 11:38 ` [PATCH v2 6/9] completion: improve handling of --detach in checkout Jacob Keller
2020-05-27 11:38 ` [PATCH v2 7/9] completion: improve handling of --track in switch/checkout Jacob Keller
2020-05-27 11:38 ` [PATCH v2 8/9] completion: improve handling of -c/-C and -b/-B " Jacob Keller
2020-05-27 11:38 ` [PATCH v2 9/9] completion: improve handling of --orphan option of switch/checkout Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimghl0ft.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).