mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Johannes Schindelin <>
Cc: Brandon Richardson <>,
	Git Mailing List <>
Subject: Re: format-patch: "magic" mbox timestamp
Date: Tue, 10 Nov 2020 15:22:54 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Johannes Schindelin's message of "Wed, 11 Nov 2020 00:12:05 +0100 (CET)")

Johannes Schindelin <> writes:

> The original magic timestamp, however, was the one I reintroduced, and as
> you can see from the part I quoted above, I only imitated the original
> script.

That's almost a lifetime ago that I totally forgot that it was
original a shell script.  

It indeed does this:

+	case "$mbox" in
+	t)
+	    echo 'From nobody Mon Sep 17 00:00:00 2001' ;# UNIX "From" line
+	    mailScript="$mailScript"'
+	    s|^|Subject: [PATCH'"$num"'] |'
+	    ;;

which clearly shows that "nobody" was chosen to mimic a real mailbox
(i.e. unlike what Brandon said in the other message, the <mailbox>
may not have "@" <domain> after <local-part>).

In any case, I think what's more important is after 15 years, if any
implementation of the /etc/magic database actually take advantage of
that magic date as the "magic" signal to identify a format-patch
output.  Despite the wishes of original authors and designers of Git
and its format-patch output, perhaps no /etc/magic author noticed it,
in which case it is safe to use other randomly picked dates, or the
timestamp of underlying commits.  Otherwise, changing the "magic"
timestamp would introduce a needless regression.

  reply	other threads:[~2020-11-10 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 21:54 format-patch: "magic" mbox timestamp Brandon Richardson
2020-11-10 23:12 ` Johannes Schindelin
2020-11-10 23:22   ` Junio C Hamano [this message]
2020-11-10 23:13 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).