From: Junio C Hamano <gitster@pobox.com>
To: "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
"Christian Couder" <christian.couder@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Hariom Verma" <hariom18599@gmail.com>
Subject: Re: [PATCH v3 0/3] Unify trailers formatting logic for pretty.c and ref-filter.c
Date: Sat, 06 Feb 2021 19:33:14 -0800 [thread overview]
Message-ID: <xmqqim74a6x1.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.726.v3.git.1612602945.gitgitgadget@gmail.com> (Hariom Verma via GitGitGadget's message of "Sat, 06 Feb 2021 09:15:41 +0000")
"Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:
> @@ t/t6300-for-each-ref.sh: test_expect_success '%(trailers:only) and %(trailers:un
> + option="$2"
> + expect="$3"
> + test_expect_success "$title" '
> -+ echo $expect >expect &&
> ++ printf "$expect\n" >expect &&
Are we sure that "$expect" would not ever have any '%' in it, to
confuse printf? To be future-proof and safe, it would be prudent to
instead use
printf "%s\n" "$expect"
to make sure that whatever is passed in $3 gets output LITERALLY.
The callers need to adopt the change I gave you in the review of the
previous round so that they do not assume backslash-en will by
changed to LF by somebody---instead if they mean LF, they just say
LF.
Thanks.
next prev parent reply other threads:[~2021-02-07 3:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 19:48 [PATCH 0/2] Unify trailers formatting logic for pretty.c and ref-filter.c Hariom Verma via GitGitGadget
2020-09-05 19:48 ` [PATCH 1/2] pretty.c: refactor trailer logic to `format_set_trailers_options()` Hariom Verma via GitGitGadget
2020-09-05 21:59 ` René Scharfe
2020-09-05 19:48 ` [PATCH 2/2] ref-filter: using pretty.c logic for trailers Hariom Verma via GitGitGadget
2021-01-29 21:09 ` [PATCH v2 0/3] Unify trailers formatting logic for pretty.c and ref-filter.c Hariom Verma via GitGitGadget
2021-01-29 21:09 ` [PATCH v2 1/3] pretty.c: refactor trailer logic to `format_set_trailers_options()` Hariom Verma via GitGitGadget
2021-01-29 23:49 ` Junio C Hamano
2021-01-29 21:09 ` [PATCH v2 2/3] pretty.c: capture invalid trailer argument Hariom Verma via GitGitGadget
2021-01-29 22:28 ` Christian Couder
2021-01-30 19:16 ` Hariom verma
2021-01-30 0:01 ` Junio C Hamano
2021-01-30 19:00 ` Hariom verma
2021-01-30 0:07 ` Junio C Hamano
2021-01-30 19:06 ` Hariom verma
2021-01-29 21:09 ` [PATCH v2 3/3] ref-filter: use pretty.c logic for trailers Hariom Verma via GitGitGadget
2021-01-30 20:45 ` Ævar Arnfjörð Bjarmason
2021-02-04 18:46 ` Hariom verma
2021-02-04 20:53 ` Ævar Arnfjörð Bjarmason
2021-01-30 1:17 ` [PATCH v2 0/3] Unify trailers formatting logic for pretty.c and ref-filter.c Junio C Hamano
2021-01-30 1:28 ` Junio C Hamano
2021-01-30 19:15 ` Hariom verma
2021-01-30 20:20 ` Junio C Hamano
2021-02-06 9:15 ` [PATCH v3 " Hariom Verma via GitGitGadget
2021-02-06 9:15 ` [PATCH v3 1/3] pretty.c: refactor trailer logic to `format_set_trailers_options()` Hariom Verma via GitGitGadget
2021-02-06 9:15 ` [PATCH v3 2/3] pretty.c: capture invalid trailer argument Hariom Verma via GitGitGadget
2021-02-06 9:15 ` [PATCH v3 3/3] ref-filter: use pretty.c logic for trailers Hariom Verma via GitGitGadget
2021-02-07 5:45 ` Junio C Hamano
2021-02-07 12:06 ` Hariom verma
2021-02-07 18:19 ` Junio C Hamano
2021-02-07 19:38 ` Hariom verma
2021-02-07 20:09 ` Junio C Hamano
2021-02-08 17:07 ` Hariom verma
2021-02-08 18:29 ` Junio C Hamano
[not found] ` <xmqqlfby5o9h.fsf@gitster.c.googlers.com>
2021-02-08 23:43 ` brian m. carlson
2021-02-09 3:04 ` brian m. carlson
2021-02-09 20:54 ` Junio C Hamano
2021-02-07 3:33 ` Junio C Hamano [this message]
2021-02-07 5:06 ` [PATCH v3 0/3] Unify trailers formatting logic for pretty.c and ref-filter.c Junio C Hamano
2021-02-13 1:52 ` [PATCH v4 0/4] " Hariom Verma via GitGitGadget
2021-02-13 1:52 ` [PATCH v4 1/4] t6300: use function to test trailer options Hariom Verma via GitGitGadget
2021-02-13 1:52 ` [PATCH v4 2/4] pretty.c: refactor trailer logic to `format_set_trailers_options()` Hariom Verma via GitGitGadget
2021-02-13 1:52 ` [PATCH v4 3/4] pretty.c: capture invalid trailer argument Hariom Verma via GitGitGadget
2021-02-13 1:52 ` [PATCH v4 4/4] ref-filter: use pretty.c logic for trailers Hariom Verma via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqim74a6x1.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).