git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Christian Walther via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Christian Walther <cwalther@gmx.ch>
Subject: Re: [PATCH] doc: mention bigFileThreshold for packing
Date: Tue, 09 Feb 2021 13:50:16 -0800	[thread overview]
Message-ID: <xmqqim70zzaf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.872.git.1612897624121.gitgitgadget@gmail.com> (Christian Walther via GitGitGadget's message of "Tue, 09 Feb 2021 19:07:03 +0000")

"Christian Walther via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Christian Walther <cwalther@gmx.ch>
>
> Knowing about the core.bigFileThreshold configuration variable is
> helpful when examining pack file size differences between repositories.
> Add a reference to it to the manpages a user is likely to read in this
> situation.

Thanks.

I doubt that the description of --window/--depth command line
options, for both repack and pack-objects, is the best place to add
this "Note".  Even if we were to add it as an appendix to these
places, please do not break the flow of explanation by inserting it
before the description of the default values of these options.

>     I recently spent a lot of time trying to figure out why git repack would
>     create huge packs on some clones of my repository and small ones on
>     others, until I found out about the existence of the
>     core.bigFileThreshold configuration variable, which happened to be set
>     on some and not on others. It would have saved me a lot of time if that
>     variable had been mentioned in the relevant manpages that I was reading,
>     git-repack and git-pack-objects. So this patch adds that.

Not related to the contents of the patch, but I am somewhat curious
to know what configuration resulted in the "huge" ones and "small"
ones.  Documentation/config/core.txt::core.bigFileThreashold may be
helped by addition of a success story, and the configuration for the
"small" ones may be a good place to start.

Thanks

  reply	other threads:[~2021-02-09 23:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 19:07 Christian Walther via GitGitGadget
2021-02-09 21:50 ` Junio C Hamano [this message]
2021-02-10 21:43   ` Christian Walther
2021-02-10 22:19     ` Junio C Hamano
2021-02-21 13:23 ` [PATCH v2] " Christian Walther via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqim70zzaf.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=cwalther@gmx.ch \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --subject='Re: [PATCH] doc: mention bigFileThreshold for packing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).