From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>
Subject: Re: ab/fsck-unexpected-type (and "cat-file replace handling and optimization")
Date: Fri, 08 Oct 2021 13:50:05 -0700 [thread overview]
Message-ID: <xmqqily7jl6q.fsf@gitster.g> (raw)
In-Reply-To: <YV+sLmlWufC5ullA@coredump.intra.peff.net> (Jeff King's message of "Thu, 7 Oct 2021 22:25:50 -0400")
Jeff King <peff@peff.net> writes:
> In this case I think neither is churn. I needed to clean up the earlier
> part of the test script so that my later tests didn't break, and Ævar
> touched the same area to cover more cases in those tests.
> ...
> One other possible thing to do during the resolution is combine the
> cleanup of both objects in a single test (since in Ævar's series, both
> objects are created together).
That is what makes it a churn X-<.
More coverage does not have to be tied to turning a sequence of
tests into a loop, moving things around, etc. Just adding more of
similar things wouldn't have caused such a clash with a possible
mismerge.
But I need to point out that it is recognised as a churn only when
there is an unfortunate topic that wants to touch the overlapping
area at the same time. If there isn't, such a change would be seen
as a valuable preliminary clean-up ;-)
So, of course, it depends on luck.
next prev parent reply other threads:[~2021-10-08 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 23:44 What's cooking in git.git (Oct 2021, #01; Mon, 4) Junio C Hamano
2021-10-04 23:52 ` Taylor Blau
2021-10-05 16:01 ` ab/refs-errno-cleanup Ævar Arnfjörð Bjarmason
2021-10-05 16:47 ` hm/paint-hits-in-log-grep Ævar Arnfjörð Bjarmason
2021-10-05 17:07 ` ab/designated-initializers-more Ævar Arnfjörð Bjarmason
2021-10-05 20:47 ` ab/fsck-unexpected-type (and "cat-file replace handling and optimization") Ævar Arnfjörð Bjarmason
2021-10-05 22:01 ` Jeff King
2021-10-06 8:54 ` Ævar Arnfjörð Bjarmason
2021-10-07 21:37 ` Junio C Hamano
2021-10-08 2:25 ` Jeff King
2021-10-08 20:50 ` Junio C Hamano [this message]
2021-10-06 10:14 ` ab/make-sparse-for-real Ævar Arnfjörð Bjarmason
2021-10-06 10:17 ` ab/parse-options-cleanup & ab/align-parse-options-help & ab/help-config-vars Ævar Arnfjörð Bjarmason
2021-10-06 16:44 ` Junio C Hamano
2021-10-06 10:26 ` ab/refs-errno-cleanup & "errno" removal in the refs backend Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqily7jl6q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).