From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: ps/avoid-unnecessary-hook-invocation-with-packed-refs
Date: Fri, 28 Jan 2022 13:14:57 -0800 [thread overview]
Message-ID: <xmqqilu3woj2.fsf@gitster.g> (raw)
In-Reply-To: <YfOd7QRK4zjLwJci@ncase> (Patrick Steinhardt's message of "Fri, 28 Jan 2022 08:40:29 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> On Mon, Jan 24, 2022 at 11:39:58AM -0800, Junio C Hamano wrote:
>> * ps/avoid-unnecessary-hook-invocation-with-packed-refs (2022-01-17) 6 commits
>> - refs: skip hooks when deleting uncovered packed refs
>> - refs: do not execute reference-transaction hook on packing refs
>> - refs: demonstrate excessive execution of the reference-transaction hook
>> - refs: allow skipping the reference-transaction hook
>> - refs: allow passing flags when beginning transactions
>> - refs: extract packed_refs_delete_refs() to allow control of transaction
>>
>> Because a deletion of ref would need to remove it from both the
>> loose ref store and the packed ref store, a delete-ref operation
>> that logically removes one ref may end up invoking ref-transaction
>> hook twice, which has been corrected.
>>
>> Introduces new leaks when merged to 'seen'.
>> source: <cover.1642406989.git.ps@pks.im>
>
> This leak was fixed in v4 of my series [1], so to the best of my
This topic has been in 'seen' and recent CI runs show there is no
failure due to leak checker. Will remove the comment. Thanks.
> knowledge there shouldn't be any more issues my series. The only
> question that remains open is Han-Wen's [2], but as I replied I'm not
> sure we actually need to adjust documentation of the flags given that we
> already do explicitly say how we pass through flags in all cases.
I'll let Han-Wen answer this first.
Thanks.
>
> Patrick
>
> [1]: https://public-inbox.org/git/cover.1642406989.git.ps@pks.im/
> [2]: https://public-inbox.org/git/CAFQ2z_M+2D-5qPXN=0FEveZ36Yq0rps3HxRkgCmiupq1DD7Kig@mail.gmail.com/
next prev parent reply other threads:[~2022-01-28 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 19:39 What's cooking in git.git (Jan 2022, #07; Mon, 24) Junio C Hamano
2022-01-25 19:45 ` Submodule UX overhaul update (was: What's cooking in git.git (Jan 2022, #07; Mon, 24)) Emily Shaffer
2022-01-26 14:09 ` Ævar Arnfjörð Bjarmason
2022-01-26 17:27 ` Emily Shaffer
2022-01-26 15:16 ` Kaartic Sivaraam
2022-01-26 16:35 ` Atharva Raykar
2022-01-26 17:43 ` Emily Shaffer
2022-01-26 17:50 ` Glen Choo
2022-01-28 7:40 ` ps/avoid-unnecessary-hook-invocation-with-packed-refs (Was: " Patrick Steinhardt
2022-01-28 21:14 ` Junio C Hamano [this message]
2022-01-31 9:50 ` flags types/names (was: ps/avoid-unnecessary-hook-invocation-with-packed-refs) Han-Wen Nienhuys
2022-01-31 17:13 ` flags types/names Junio C Hamano
2022-01-28 22:31 ` What's cooking in git.git (Jan 2022, #07; Mon, 24) brian m. carlson
2022-02-04 0:27 ` Junio C Hamano
2022-02-04 17:27 ` René Scharfe
2022-02-02 11:28 ` ab/auto-detect-zlib-compress2 (was: What's cooking in git.git (Jan 2022, #07; Mon, 24)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilu3woj2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).