From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=0.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 060581F670 for ; Thu, 3 Mar 2022 01:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbiCCBLZ (ORCPT ); Wed, 2 Mar 2022 20:11:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbiCCBLX (ORCPT ); Wed, 2 Mar 2022 20:11:23 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E488D159E82 for ; Wed, 2 Mar 2022 17:10:39 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E090A11D519; Wed, 2 Mar 2022 20:10:38 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=PB9UIjylO95CkRqHXVJ+msWNZFZX6wMlm+hZt9 frqBY=; b=ZHhVTgYM5xQnqIA9HkbX0tDR6iMciPxxRUEl3ZJt2E3ZmgiyETr6gO 9DGyWH+Qa6+iMjbCeYISsXXlNjR8tc09VLYcsARcIi76bmkJQHjdMC0zN9XzUZiQ KMhrfJ4DJjNUyAPIa1qmrOWfzSWxWWWuBMinvAc8uL7mNQt4wwfNI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D7BF811D518; Wed, 2 Mar 2022 20:10:38 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4830411D516; Wed, 2 Mar 2022 20:10:38 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Keller, Jacob E" Cc: Derrick Stolee , Jacob Keller , Git mailing list Subject: Re: [PATCH] name-rev: use generation numbers if available References: <20220228215025.325904-1-jacob.e.keller@intel.com> <20220228215025.325904-3-jacob.e.keller@intel.com> <6b00c67b-01c9-bf22-a8e6-904f47fa7acf@github.com> <3c3e6063-7eb4-7ff4-3a1b-a07db1fe969f@github.com> Date: Wed, 02 Mar 2022 17:10:37 -0800 In-Reply-To: (Jacob E. Keller's message of "Tue, 1 Mar 2022 22:46:06 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: BCAD1BEA-9A8E-11EC-A828-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Keller, Jacob E" writes: > Let's clarify. There are two versions of the test in this version: > > 1) test which enables commit graph and tests that it does the right behavior. > > 2) test which removes commit graph and tests that it behaves the old way. > > > test (1) checks the flow with the commit graph enabled, and verifies that with a commit graph the new behavior is used. This test will fail if you revert the name-rev commit-graph support. > > test (2) always performs the way we don't like. (since we disable the commit graph and the new flow doesn't kick in) This is the test I think I will eliminate in the next revision. > > > I will remove the 2nd test, since the first test covers the change > in behavior just fine, and I think I agree we don't need to set > in-stone the implementation without commit graph. > > I will also look at adding a test which performs a count of which > revisions get inspected and makes sure that we actually are doing > the optimization. Sounds like a sensible thing to do. In any case, in the current patch, #2 is not working in linux-TEST-vars job at CI. You can visit this URL https://github.com/git/git/runs/5400048732?check_suite_focus=true#step:4:68062 while logged into your GitHub account for details. Thanks.