From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 1C3901F670 for ; Mon, 7 Mar 2022 17:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237853AbiCGRMo (ORCPT ); Mon, 7 Mar 2022 12:12:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbiCGRMn (ORCPT ); Mon, 7 Mar 2022 12:12:43 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E2C783021 for ; Mon, 7 Mar 2022 09:11:48 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BAFA210CEC6; Mon, 7 Mar 2022 12:11:47 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=jCdhyjl3/GcfgNmZ0HvEceqiBEP7tKP/P4u0dq GWMRA=; b=Ufa3WnM7t7Fz8VSKVhjUoG5wE1HAaaXSFlIFKn3mxXlnAqGrv3tJ35 rPwJvMpxrL/0DOKLxH0UTBSYerZ0iiaCTurrz02uaXsMt2/kpqzAa9bNX0ffwVId M+zdSmUWF9sVJ2CYEwkNqCRJFcmpaSb6Yj4JcR4OA/LyrRHh+brk8= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B31FB10CEC5; Mon, 7 Mar 2022 12:11:47 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.230.65.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 25CE110CEC4; Mon, 7 Mar 2022 12:11:47 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: phillip.wood@dunelm.org.uk, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Johannes Schindelin via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH 0/9] ci: make Git's GitHub workflow output much more helpful References: <220220.86bkz1d7hm.gmgdl@evledraar.gmail.com> <220222.86tucr6kz5.gmgdl@evledraar.gmail.com> <505afc19-25bd-7ccb-7fb2-26bcc9d47119@gmail.com> <30dbc8fb-a1db-05bc-3dcb-070e11cf4715@gmail.com> Date: Mon, 07 Mar 2022 09:11:46 -0800 In-Reply-To: (Johannes Schindelin's message of "Mon, 7 Mar 2022 17:07:41 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: ABA5DA4A-9E39-11EC-979B-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: >> One thing I forgot to mention was that when you expand a failing test it shows >> the test script twice before the output e.g. >> >> Error: failed: t7527.35 Matrix[uc:false][fsm:true] enable fsmonitor >> failure: t7527.35 Matrix[uc:false][fsm:true] enable fsmonitor >> git config core.fsmonitor true && >> git fsmonitor--daemon start && >> git update-index --fsmonitor >> >> expecting success of 7527.35 'Matrix[uc:false][fsm:true] enable fsmonitor': >> git config core.fsmonitor true && >> git fsmonitor--daemon start && >> git update-index --fsmonitor >> >> ++ git config core.fsmonitor true >> ++ git fsmonitor--daemon start >> ... >> >> I don't know how easy it would be to fix that so that we only show "expecting >> success of ..." without the test being printed first > > It's not _super_ easy: right now, the patch series does not touch the code In other words, it is not a new issue introduced by this series, right? > The easiest workaround would probably to add a flag that suppresses the > header `expecting success` in case we're running with the > `--github-workflow-markup` option. If that is the case, let's leave it outside the series. If we do not have to hide the solution behind any option specific to "--github-workflow-markup", then even users (like me) who reguarly run "cd t && sh ./t1234-a-particular-test.sh -i -v" would benefit if we no longer have to look at the duplicated test script in the output. Thanks.