From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 443E61F4D7 for ; Mon, 13 Jun 2022 20:26:03 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="UUEgYFPv"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344231AbiFMUZ7 (ORCPT ); Mon, 13 Jun 2022 16:25:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345301AbiFMUZt (ORCPT ); Mon, 13 Jun 2022 16:25:49 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B31E994 for ; Mon, 13 Jun 2022 12:10:27 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 29FE8136872; Mon, 13 Jun 2022 15:10:27 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=u9lcNhJSVLGD bgoIdahPLDyDZLqjcRBPtK5hTt7/V6Y=; b=UUEgYFPv/xIVzOFoBq8pHOKuuYxu up/52fjyZt6XWy81EiJHaxzXlroLjWNo7PpIfOyHWxGFcboBYg32YuwUY/H3TuIA AiVnzbeHg80kaCz3lCc714e0eSwYQ7U90aU+zqn5YETtkRuRLADSXeKocmqirPZf 7EOoETNEEb5aAvU= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 1EF38136871; Mon, 13 Jun 2022 15:10:27 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 86FF2136870; Mon, 13 Jun 2022 15:10:26 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?Q?Ren=C3=A9?= Scharfe Cc: git@vger.kernel.org, Johannes Schindelin , Rohit Ashiwal , =?utf-8?B?w4Z2YXIgQXJuZmo=?= =?utf-8?B?w7Zyw7A=?= Bjarmason , Jeff King , "brian m . carlson" Subject: Re: [PATCH v3 3/5] archive-tar: add internal gzip implementation References: <217a2f4d-4fc2-aaed-f5c2-1b7e134b046d@web.de> <75e76d0f-2ab0-ebf7-4a4e-7a6e0fca0b1a@web.de> Date: Mon, 13 Jun 2022 12:10:25 -0700 In-Reply-To: <75e76d0f-2ab0-ebf7-4a4e-7a6e0fca0b1a@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Sun, 12 Jun 2022 08:08:35 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 7B9F02D0-EB4C-11EC-9B39-CB998F0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ren=C3=A9 Scharfe writes: > @@ -148,7 +148,8 @@ tar..command:: > format is given. > + > The "tar.gz" and "tgz" formats are defined automatically and default t= o > -`gzip -cn`. You may override them with custom commands. > +`gzip -cn`. You may override them with custom commands. An internal gz= ip > +implementation can be used by specifying the value `git archive gzip`. > The new sentence didn't click and I was lost in figuring out what is set to which value and where, before looking at a test the patch adds. I think it is not entirely a fault of this patch, but the badness is already in the original. I wouldn't have been as confused if it were like so: The "tar.gz" and "tgz" formats are defined automatically to use `gzip -cn` as the command by default. An internal gzip implementation can be used by specifying the value `git archive gzip` for these two formats. for example. Thanks.