From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5CF031F54E for ; Wed, 7 Sep 2022 19:46:21 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kgZYYh3O"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbiIGTqA (ORCPT ); Wed, 7 Sep 2022 15:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiIGTp7 (ORCPT ); Wed, 7 Sep 2022 15:45:59 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02BA39F75B for ; Wed, 7 Sep 2022 12:45:58 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso10968071pjd.4 for ; Wed, 07 Sep 2022 12:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:sender:from:to:cc :subject:date; bh=mAYDyxkd2dXYQ8GETTcWWngGkSag7yll75SCE+bHG98=; b=kgZYYh3OshDneTkM7YclTiHr6lF0fSFY3qMpsWzGmZmoPoit29gtHc4KYwcXfZwOwQ ujqaXrDkL5Cwe1FTIpcm6r2TeiQ/zROqdG+cTd1td8RFgoNuCsvKI8Dz7j6hXtOA+Rsr ydMcdr3mlDVhcO047hPVTZVwH0bhT9IBRxenosjWtLGSxxrynbAA68o7zc+QYa+02Y7S Pd21HdAWu4nJ93hPadCHl91rvXEBYYt6nVvQfqg6+9MgCx6xJTyT9F4KrZSp6zHiHg3Y UAarwYmQ8bfcdmAwNBGgcwOHApSWVxu+blDy/dBJjQ6wHaH+p8A6nTUUmrvxaxpHB27u EvEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:sender :x-gm-message-state:from:to:cc:subject:date; bh=mAYDyxkd2dXYQ8GETTcWWngGkSag7yll75SCE+bHG98=; b=kcV7WoG7enMcySK/VjzVD3Tpd9HhDawr1CJE+KUNfhJPaOotIOWPwtAUBpjJQvvx82 335ItSSmfV9gEAYE1sxHdXBSAB7mMfBbAd1daVHDC3y2z8bc7pjejkmqHhHMMkOW36ZO wYzY20tHFo0aK7OuZgnsPBJtUg/PKbTFfpMYIx6xRRbujPPBO+FNRocXIDYLyGsJHY/e oh3XE/sIAn928rotYjRGLGygMksdZmrDr7i1QV+gP3R40QHllUHwrKdpeYaWd2BD6nH3 FpBOSGjH6CPw/ozpm2TtqZFpmt2Usaj7PaCmR1RQgFyX85SCGIL4L02yLSwe9HaZcbOd g5qQ== X-Gm-Message-State: ACgBeo0zuK8fBBV0A9WlhP4Dsh0j0rquRCbgZXTwEltW3/gvpBhGBhSZ mGBzQ8x78y/mpr08S5gv3/Q= X-Google-Smtp-Source: AA6agR5Hhk76RVammkxTKZRRqqli4pS3PCiWnfPI0uXVq1s+/RzG/vKfykrwitc+eEZNsFo+8tfwBQ== X-Received: by 2002:a17:903:248:b0:172:7520:db07 with SMTP id j8-20020a170903024800b001727520db07mr5102852plh.76.1662579957412; Wed, 07 Sep 2022 12:45:57 -0700 (PDT) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id n13-20020a170903110d00b0015e8d4eb26esm12822642plh.184.2022.09.07.12.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 12:45:56 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH v2 2/2] tests: replace mingw_test_cmp with a helper in C References: <1f5366f137967cbec30041b40eedd86ce5f6e953.1662469859.git.gitgitgadget@gmail.com> <220907.86v8pzl6jz.gmgdl@evledraar.gmail.com> <220907.86r10nl63s.gmgdl@evledraar.gmail.com> Date: Wed, 07 Sep 2022 12:45:56 -0700 In-Reply-To: <220907.86r10nl63s.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 07 Sep 2022 14:24:26 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ævar Arnfjörð Bjarmason writes: > But I think that re-raises the point René had in: > https://lore.kernel.org/git/b21d2b60-428f-58ec-28b6-3c617b9f2e45@web.de/ As the primary point of no-index mode was to expose fancy options "git diff" has to comparisons of files outside version control, without having to go through the trouble of upstreaming changes to GNU diff, I do think "--ignore-cr-at-eol" should work fine with it, and René's idea sounds like the best implementation for the test-text-cmp helper command. Thanks.