git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Todd Zullinger <tmz@pobox.com>, git@vger.kernel.org
Subject: Re: t5559 breaks with apache 2.4.55
Date: Fri, 10 Feb 2023 18:34:43 -0800	[thread overview]
Message-ID: <xmqqilg9exq4.fsf@gitster.g> (raw)
In-Reply-To: <Y+b7bTs2vdXAe/ky@coredump.intra.peff.net> (Jeff King's message of "Fri, 10 Feb 2023 21:20:29 -0500")

Jeff King <peff@peff.net> writes:

> I'm not sure this is really sufficient. As I was running t5559 over and
> over to test various versions, I noticed a few other cases that seemed
> to fail, some of them racily. So I'm a bit worried that the problem may
> be more extensive, and it is only that this particular test happened to
> trigger it reliably.

Yeah, I've seen not just t5559.30 (which is what the patch was
about) reliably fail, but t5559.25 fail only from time to time.
There may be others.

> In which case the right solution may be ditching t5559, or at the very
> least adding a knob or version check to disable it.

Yup.  Do we have an example of checking versions of mod_frob being
used from within our test suite?  I didn't locate one.

> So I'm tempted to just punt for now and see how often this bites people
> in the real world. And if it does become a problem, we'll have more data
> on what exactly should be changed.

OK, works for me.

Thanks.


  reply	other threads:[~2023-02-11  2:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22  8:00 t5559 breaks with apache 2.4.55 Jeff King
2023-01-22 16:33 ` Todd Zullinger
2023-01-26 11:39   ` Jeff King
2023-01-29  6:35     ` Jeff King
2023-02-09 21:45       ` Junio C Hamano
2023-02-11  2:20         ` Jeff King
2023-02-11  2:34           ` Junio C Hamano [this message]
2023-02-11  3:00             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqilg9exq4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).