From: Junio C Hamano <gitster@pobox.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, phillip.wood123@gmail.com
Subject: Re: [PATCH v3] branch, for-each-ref, tag: add option to omit empty lines
Date: Fri, 07 Apr 2023 11:48:05 -0700 [thread overview]
Message-ID: <xmqqile7jzq2.fsf@gitster.g> (raw)
In-Reply-To: <20230407175316.6404-1-oystwa@gmail.com> ("Øystein Walle"'s message of "Fri, 7 Apr 2023 19:53:16 +0200")
Øystein Walle <oystwa@gmail.com> writes:
> If the given format string expands to the empty string a newline is
> still printed it. This makes using the output linewise more tedious. For
> example, git update-ref --stdin does not accept empty lines.
>
> Add options to branch and for-each-ref to not print these empty lines.
> The default behavior remains the same.
>
> Signed-off-by: Øystein Walle <oystwa@gmail.com>
> ---
> Dang, you're right. But yes, it was a near-identical patch to
> builtin/tag.c. Along with a test, of course.
There are small nits like "do not explicitly initialize statics to
0", which may not be big enough to warrant a reroll. Other than
that, looking good.
Thanks, will replace.
next prev parent reply other threads:[~2023-04-07 18:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:21 [PATCH 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-03-30 11:21 ` [PATCH 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-03-30 15:21 ` Junio C Hamano
2023-03-30 15:25 ` Junio C Hamano
2023-03-31 10:37 ` Øystein Walle
2023-03-31 10:57 ` ZheNing Hu
2023-03-31 16:19 ` Junio C Hamano
2023-04-06 17:08 ` [PATCH v2 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 17:08 ` [PATCH v2 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-04-06 17:08 ` [PATCH v2 2/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 18:24 ` [PATCH v2 0/2] " Junio C Hamano
2023-04-07 17:53 ` [PATCH v3] branch, for-each-ref, tag: " Øystein Walle
2023-04-07 18:48 ` Junio C Hamano [this message]
2023-04-12 23:44 ` Andrei Rybak
2023-04-13 7:17 ` Øystein Walle
2023-04-13 15:13 ` Junio C Hamano
2023-03-30 11:21 ` [PATCH 2/2] branch, for-each-ref: " Øystein Walle
2023-03-30 15:54 ` Junio C Hamano
2023-03-30 18:25 ` Jeff King
2023-03-30 18:54 ` Junio C Hamano
2023-03-31 8:32 ` Øystein Walle
2023-03-31 15:57 ` Junio C Hamano
2023-03-30 17:21 ` Junio C Hamano
2023-03-31 16:33 ` Phillip Wood
2023-03-31 17:17 ` Junio C Hamano
2023-04-06 16:55 ` Øystein Walle
2023-04-06 17:12 ` Jeff King
2023-04-06 18:20 ` Junio C Hamano
2023-04-10 19:56 ` Jeff King
2023-04-06 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqile7jzq2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).