From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: X-Spam-Status: No, score=1.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, LIST_MIRROR_RECEIVED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4A97B1F406 for ; Sun, 15 Oct 2023 17:04:45 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=df5WZUzw; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9453D1C2093F for ; Sun, 15 Oct 2023 17:04:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B87ADE578; Sun, 15 Oct 2023 17:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="df5WZUzw" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99762210A for ; Sun, 15 Oct 2023 17:04:35 +0000 (UTC) Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65B4BAB for ; Sun, 15 Oct 2023 10:04:32 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8F9991BA610; Sun, 15 Oct 2023 13:04:28 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=D0UfQzWPIFafRVbZybA4KP3cZSX2A71Ht1x7gY Cdj6A=; b=df5WZUzw1Uwu0bZ+D8Fn/QoJ7imbG/hE7InKPMRcAhwoYMHF6Pd1G2 i5IQMcmtFUron8YmKAjwOgnDZo0mdlpANf07ZUOZezyL7Pt0Jh0c6iSiJAGfAS5i AXKmqtTRCYFBzPbW5cg5V9FQJO0Lo4b3D0hdp6/1yYxeBtzHUukJg= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 86A271BA60F; Sun, 15 Oct 2023 13:04:28 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.153.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id DE75C1BA60E; Sun, 15 Oct 2023 13:04:27 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: git@vger.kernel.org, Taylor Blau Subject: Re: [PATCH 21/20] t5319: make corrupted large-offset test more robust In-Reply-To: <20231015031732.GB554702@coredump.intra.peff.net> (Jeff King's message of "Sat, 14 Oct 2023 23:17:32 -0400") References: <20231009205544.GA3281950@coredump.intra.peff.net> <20231014004348.GA43880@coredump.intra.peff.net> <20231015031732.GB554702@coredump.intra.peff.net> Date: Sun, 15 Oct 2023 10:04:26 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E6518542-6B7C-11EE-89EB-25B3960A682E-77302942!pb-smtp2.pobox.com List-Unsubscribe-Post: List-Unsubscribe=One-Click Jeff King writes: > Yeah, I had a similar thought process. I sort of assume anybody working > on git.git is capable of turning to "git blame" in a situation like > this. But maybe: > > # using only %(objectsize) is important here; run "git blame" > # on these lines for more details > > would spell it out more clearly. The comment was about "the commit" being not so clear which commit. "see the message of the commit that added this comment" would have been perfectly fine and they are not required to use "blame" if they don't like it.