git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Paul Smith <psmith@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile(s): avoid recipe prefix in conditional statements
Date: Tue, 09 Apr 2024 14:23:44 -0700	[thread overview]
Message-ID: <xmqqil0q1b8f.fsf@gitster.g> (raw)
In-Reply-To: <95f2454e449cc0126aaa40d2ab08c76b55ee3c31.camel@gnu.org> (Paul Smith's message of "Tue, 09 Apr 2024 16:42:14 -0400")

Paul Smith <psmith@gnu.org> writes:

> I'm not sure I understand the suggestion here.  If I preserve the
> current parsing behavior what do I tell people who cannot get their
> makefiles to work because the current parsing doesn't allow it?

Their Makefiles were not working (perhaps began with HT followed by
a command whose name happened to be "ifdef" installed in ~/bin/ifdef
or something silly like that) before your "fix" to forbid using HT
to indent conditional, so your "fix" is not breaking them any
further.

If you optionally allow .if/.else etc., you can tell them to replace
their "ifdef" with ".ifdef".  Of course you can also tell them to
replace their HT indent before "ifdef" to spaces.

But the point is that those whose Makefiles were not parsed correctly
even before your "fix" need to fix their Makefiles anyway.  The
suggestion was about helping those whose Makefiles were happily been
grokked somehow before your "fix".  If you preserve the current code,
their Makefiles that indent their "ifdef" with HT will continue to
work, so you do not have to tell them anything, no?


  reply	other threads:[~2024-04-09 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 10:44 Makefiles are broken as of GNU Make commit 07fcee35f058a876447c8a021f9eb1943f902534 Dario Gjorgjevski
2024-04-08 15:51 ` [PATCH] Makefile(s): avoid recipe prefix in conditional statements Taylor Blau
2024-04-08 21:41   ` Junio C Hamano
2024-04-08 23:24     ` Paul Smith
2024-04-08 23:34       ` Junio C Hamano
2024-04-09 20:41         ` Paul Smith
2024-04-08 23:44       ` Junio C Hamano
2024-04-09 20:42         ` Paul Smith
2024-04-09 21:23           ` Junio C Hamano [this message]
2024-04-09  0:04       ` Jeff King
2024-04-09  0:17         ` Jeff King
2024-04-09 20:44         ` Paul Smith
2024-04-08 23:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqil0q1b8f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=psmith@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).