From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] imap-send: increase command size limit
Date: Mon, 15 Apr 2024 11:38:28 -0700 [thread overview]
Message-ID: <xmqqil0impy3.fsf@gitster.g> (raw)
In-Reply-To: <ZhwV6CmcC8zeSJ-7@tapette.crustytoothpaste.net> (brian m. carlson's message of "Sun, 14 Apr 2024 17:44:08 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> ...
>> Suggested-by: Jeff King <peff@peff.net>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>> This time I compiled with NO_CURL=1 and NO_APPLE_COMMON_CRYPTO=1 and
>> verified with a silly printf that the changed code was actually used
>> and wrote the present message to an IMAP folder whose name is 1006
>> characters log, which required a 1026 bytes long APPEND command. Yay,
>> freedom!
>
> I'm curious, is there a particular problem that you (or someone else)
> ran into that caused you to make this change? I agree it seems prudent
> in general, but if there's a particular real-world broken case that this
> hits (e.g., mailbox names in a given language), I think the commit
> message would be a great place to mention this real-world impact, which
> would lend support to your argument that this is a valuable change to
> make.
I personally am not curious about real-world problem in this case,
but I won't stop you asking ;-)
I view this more about code simplification. We no longer need a
custom nfvasprintf() helper nobody else cares about, leaving the
resulting code easier to read.
Will queue but will wait for a day or two to see if René wants to
add clarification to the proposed commit log message before merging
it to 'next'.
Thanks, both.
next prev parent reply other threads:[~2024-04-15 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 16:47 [PATCH] imap-send: increase command size limit René Scharfe
2024-04-14 17:44 ` brian m. carlson
2024-04-15 18:38 ` Junio C Hamano [this message]
2024-04-15 18:45 ` Jeff King
2024-04-16 15:31 ` René Scharfe
2024-04-15 18:55 ` Jeff King
2024-04-16 16:08 ` René Scharfe
2024-04-17 0:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqil0impy3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).